Skip to content

quality: enable repeatable Radeon Windows Vulkan qualification - #154

Draft
proggeramlug wants to merge 5 commits into
codex/rendering-wip-integrated-20260727from
codex/issue-153-radeon760m
Draft

quality: enable repeatable Radeon Windows Vulkan qualification#154
proggeramlug wants to merge 5 commits into
codex/rendering-wip-integrated-20260727from
codex/issue-153-radeon760m

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

Windows qualification could not reach reliable captures: the runner resolved scene executables from the wrong directory, Vulkan surfaces lacked their owning HINSTANCE, screenshot export unconditionally swapped red/blue, and DPI/window borders changed manifest resolutions. This change fixes those paths and adds an explicit Radeon 760M Vulkan measurement profile with native Windows CPU preflight/postflight sampling and adapter validation.

The profile retains strict visual/telemetry checks and labels performance as measurement-only until Radeon budgets are reviewed. Hash-governed textual glTF fixtures retain LF endings on Windows.

Validation:

  • All nine assets and approved baselines validate.
  • Python runner tests: 23 passed. PNG round-trip regression test passes for RGBA/BGRA, sRGB/linear formats and padded rows.
  • Two complete nine-case runs: 7 pass / 2 strict visual failures; repeatability PASS with 257 byte-identical artifacts. Hardware ray-query GI is confirmed on Radeon Vulkan.
  • All five negative controls detect seeded regressions.
  • The two failing images are also byte-identical at the original approved-baseline source revision on this host, ruling out the intervening renderer changes in this configuration.
  • The file-line gate still reports nine pre-existing failures in unchanged files; edited files add no new violation.

Evidence and measurements | Complete ZIP

ZIP SHA-256: aa099676ecd801ebb7ed586ddb9f9732b8f913f13a6d926604ad193b078d82a4

Related: #153, #128. This PR targets the rendering integration branch underlying #147. It does not close the original RTX 4080 hardware gate or change approved baselines/thresholds.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant