Skip to content

Execute Windows CI and fix six canonical example link failures - #160

Draft
proggeramlug wants to merge 2 commits into
codex/windows-engine-qualificationfrom
codex/windows-examples-ci
Draft

Execute Windows CI and fix six canonical example link failures#160
proggeramlug wants to merge 2 commits into
codex/windows-engine-qualificationfrom
codex/windows-examples-ci

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Windows CI could report success without executing its Bash entry point under PowerShell. Select Bash explicitly and require shared-test and Windows-build summary artifacts. Once Cargo actually ran, Git Bash's hard-link utility shadowed the Microsoft linker; restore the active MSVC toolchain ahead of Git's tools in the shared entry point.

Six canonical examples still used the removed runtime Color export. Switch palette accesses to Colors while retaining Color type annotations. All six compile and link with the same pinned Perry 0.5.1182 compiler, bringing that toolchain's local audit from 13/20 to 19/20 successful executables.

Validation: local contract checks pass. Configured-MSVC and missing-MSVC controls produce the expected passing and failing summaries. At 636b69a, the hosted Windows native build actually invokes Microsoft's linker, compiles bloom-windows, and passes. The hosted Windows shared suite now exposes visibility/indirect-draw GPU failures and a process crash; it remains a required failure. Both focused rendering failures also reproduce on the local Radeon under DX12 and are under investigation.

The embedded-view example links with matching Perry 0.5.1220 source libraries. A follow-up is validating a common runtime profile and adding required native linking of all 20 examples. Real startup and clean installation remain open.

See the report. This draft is stacked on #159 and advances #140, #142, and #74; it does not close those broader requirements.

The published build evidence retains the initial Windows linker failure, corrected native build, six palette fixes, and the all-example follow-up in #161. The latter now links 20/20 both locally and in hosted Windows CI. The shared GPU failures and earlier crash remain open.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant