Execute Windows CI and fix six canonical example link failures - #160
Draft
proggeramlug wants to merge 2 commits into
Draft
Execute Windows CI and fix six canonical example link failures#160proggeramlug wants to merge 2 commits into
proggeramlug wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI could report success without executing its Bash entry point under PowerShell. Select Bash explicitly and require shared-test and Windows-build summary artifacts. Once Cargo actually ran, Git Bash's hard-link utility shadowed the Microsoft linker; restore the active MSVC toolchain ahead of Git's tools in the shared entry point.
Six canonical examples still used the removed runtime
Colorexport. Switch palette accesses toColorswhile retainingColortype annotations. All six compile and link with the same pinned Perry 0.5.1182 compiler, bringing that toolchain's local audit from 13/20 to 19/20 successful executables.Validation: local contract checks pass. Configured-MSVC and missing-MSVC controls produce the expected passing and failing summaries. At
636b69a, the hosted Windows native build actually invokes Microsoft's linker, compilesbloom-windows, and passes. The hosted Windows shared suite now exposes visibility/indirect-draw GPU failures and a process crash; it remains a required failure. Both focused rendering failures also reproduce on the local Radeon under DX12 and are under investigation.The embedded-view example links with matching Perry 0.5.1220 source libraries. A follow-up is validating a common runtime profile and adding required native linking of all 20 examples. Real startup and clean installation remain open.
See the report. This draft is stacked on #159 and advances #140, #142, and #74; it does not close those broader requirements.
The published build evidence retains the initial Windows linker failure, corrected native build, six palette fixes, and the all-example follow-up in #161. The latter now links 20/20 both locally and in hosted Windows CI. The shared GPU failures and earlier crash remain open.