Fix FXC layered-material compilation with explicit lookup LOD - #165
Draft
proggeramlug wants to merge 1 commit into
Draft
Fix FXC layered-material compilation with explicit lookup LOD#165proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layered-material pipelines fail to compile with DX12/FXC when a sheen lookup uses implicit derivatives inside varying light loops. FXC attempts to unroll the loops and reports X3570/X3511, preventing four existing rendering goldens from reaching their image assertions.
Sample the single-mip sheen lookup table at explicit level zero. The shared helper keeps its texture, sampler and coordinates; existing rendering assertions and baselines are unchanged. This is stacked on #164 and does not fix the separate WARP/DXIL concurrency defect.
Validation on the Radeon 760M:
The FXC raster goldens require the physical Radeon adapter. Ray-query goldens retain their explicit DXC requirement; some library helpers select software adapters. Existing ignored tests remain recorded. Hosted Tests run 34555112391 passes all 22 jobs, including actual Windows shared execution, the native build and all 20 example links. Hosted Windows goldens skip the CPU adapter; physical image evidence comes from the local Radeon and hosted Metal runs. Canonical Metal captures and quality contracts pass; named full-hardware quality jobs remain skipped. Native/browser starter startup, packaging, wider engine acceptance and unavailable hardware qualification remain open.
Relates to #140, #128 and #153. Local evidence includes the original compiler failures, the source-equivalence receipt between #163/#164, the exact candidate patch and complete validation logs.
Published report and evidence include original compiler failures, the exact tested shader patch and complete local/hosted results. ZIP SHA-256:
8fc1a6af07b975a14ecc4d3b09b35c3db1967038b590d8ebca869528a9810b7b.