Fix installed Windows Jolt linking and verify native startup - #167
Draft
proggeramlug wants to merge 1 commit into
Draft
Fix installed Windows Jolt linking and verify native startup#167proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An installed Windows package ignores the shipped Jolt archives because its build script searches
windows-x64, while the published dependency useswin32-x64. After resolving that mismatch, Perry still requests the archives from an absent CMake output directory, despite Rust already bundling them into the engine static library.Resolve the published directory with the old spelling retained for staged CI archives, and remove the redundant Windows manifest libraries/source-build path. Add a required fresh pack/install/native startup check using the pinned Perry toolchain. The fixture simulates a falling Jolt body and renders a known frame; the gate checks every pixel and rejects a CMake fallback, missing capture, runtime error or physics-failure image.
Local validation passes: a fresh package installs Jolt 0.4.1, links without CMake, and renders all 16,384 expected pixels on Radeon DX12 and Vulkan. The two PNGs are byte-identical. Blank-frame and physics-failure-color controls are rejected. Complete contracts, formatting and strict Clippy pass, including the legacy staged-archive lookup. Original failures and exact source/package/compiler hashes are retained.
Stacked on #166. Hosted Tests run 34557843801 passes all 22 jobs, including the fresh installed native startup with all expected pixels, native engine build and all 20 example links. Hosted source trees match the PR head. The native test uses a headless renderer and the validated Perry 0.5.1220 source/runtime profile; local DX12 has SDK compiler DLLs on PATH. Visible presentation, packaged DXC, general long-path support, direct-2D capture and the full native/browser starter remain open. Relates to #140, #142 and #145.
Published report and evidence retain the original package/link failures, exact source, fresh installed physics and image checks, and all final hosted results. ZIP SHA-256:
2b53e68cf459bb5d8c6efb74384c0791f11795e43e97fba36ac3cf7f808b8f0a.