fix(android): apply Google Pay button borderRadius via ButtonOptions#68
Merged
fix(android): apply Google Pay button borderRadius via ButtonOptions#68
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
RhysAtBolt
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Routes the Google Pay button's
borderRadiusprop through Google's supportedButtonOptions.Builder.setCornerRadius(int)API. The previous implementation tried to clip the hostFrameLayoutviaViewOutlineProvider/clipToOutline, but that has no visible effect becausePayButtonrenders its own background drawable. Since corner radius lives on the immutableButtonOptions, changes now triggerrebuildButton()— same pattern already used forbuttonTypeandbuttonTheme. Also bumps the example app to demo the prop withborderRadius={25}.Testing
./gradlew :boltpay_react-native:compileDebugKotlinbuilds clean.PayButtonrendering is a Google-side concern, and the wiring is a thin pass-through.Security Review
Important
A security review is required for every PR in this repository to comply with PCI requirements.
Security Impact Summary
No security-sensitive changes. This PR only adjusts how a presentation prop (
borderRadius) is forwarded to Google's Pay button rendering API on Android. It does not touch authentication, authorization, payment tokenization flows, user data handling, or external integrations.