Skip to content

fix(android): apply Google Pay button borderRadius via ButtonOptions#68

Merged
arstiefel merged 1 commit intomainfrom
fix-android-apply-google-pay
Apr 29, 2026
Merged

fix(android): apply Google Pay button borderRadius via ButtonOptions#68
arstiefel merged 1 commit intomainfrom
fix-android-apply-google-pay

Conversation

@arstiefel
Copy link
Copy Markdown
Collaborator

Description

Routes the Google Pay button's borderRadius prop through Google's supported ButtonOptions.Builder.setCornerRadius(int) API. The previous implementation tried to clip the host FrameLayout via ViewOutlineProvider / clipToOutline, but that has no visible effect because PayButton renders its own background drawable. Since corner radius lives on the immutable ButtonOptions, changes now trigger rebuildButton() — same pattern already used for buttonType and buttonTheme. Also bumps the example app to demo the prop with borderRadius={25}.

Testing

  • Verified ./gradlew :boltpay_react-native:compileDebugKotlin builds clean.
  • Manual test: run the example app on Android, observe the Google Pay button on the AddCard screen renders with rounded corners (25dp). Toggle the value to confirm changes rebuild the button correctly.
  • No unit tests added — PayButton rendering is a Google-side concern, and the wiring is a thin pass-through.

Security Review

Important

A security review is required for every PR in this repository to comply with PCI requirements.

  • I have considered and reviewed security implications of this PR and included the summary below.

Security Impact Summary

No security-sensitive changes. This PR only adjusts how a presentation prop (borderRadius) is forwarded to Google's Pay button rendering API on Android. It does not touch authentication, authorization, payment tokenization flows, user data handling, or external integrations.

@arstiefel arstiefel requested review from a team as code owners April 29, 2026 14:32
@snyk-io
Copy link
Copy Markdown
Contributor

snyk-io Bot commented Apr 29, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@arstiefel arstiefel merged commit 74044fb into main Apr 29, 2026
7 checks passed
@arstiefel arstiefel deleted the fix-android-apply-google-pay branch April 29, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants