Skip to content

fix(android): apply Google Pay button borderRadius via ButtonOptions #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arstiefel merged 1 commit into from
Apr 29, 2026
Merged

fix(android): apply Google Pay button borderRadius via ButtonOptions #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions android/src/main/java/com/boltreactnativesdk/GooglePayButtonView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
package com.boltreactnativesdk

import android.content.Context
import android.graphics.Outline
import android.view.View
import android.view.ViewOutlineProvider
import android.widget.FrameLayout
import com.facebook.react.bridge.ReactContext
import com.facebook.react.uimanager.UIManagerHelper
Expand All @@ -20,25 +17,16 @@ class GooglePayButtonView(context: Context) : FrameLayout(context) {

private var currentButtonType: String = "plain"
private var currentButtonTheme: String = "dark"
private var cornerRadiusPx: Float = 0f
private var cornerRadiusPx: Int = 0

init {
rebuildButton()
}

fun updateBorderRadius(radiusPx: Float) {
fun updateBorderRadius(radiusPx: Int) {
if (radiusPx == cornerRadiusPx) return
cornerRadiusPx = radiusPx
if (radiusPx > 0f) {
outlineProvider = object : ViewOutlineProvider() {
override fun getOutline(view: View, outline: Outline) {
outline.setRoundRect(0, 0, view.width, view.height, radiusPx)
}
}
clipToOutline = true
} else {
outlineProvider = ViewOutlineProvider.BACKGROUND
clipToOutline = false
}
rebuildButton()
}

fun updateButtonType(type: String) {
Expand All @@ -60,6 +48,7 @@ class GooglePayButtonView(context: Context) : FrameLayout(context) {
val options = ButtonOptions.newBuilder()
.setButtonType(mapButtonType(currentButtonType))
.setButtonTheme(mapButtonTheme(currentButtonTheme))
.setCornerRadius(cornerRadiusPx)
.setAllowedPaymentMethods(ALLOWED_PAYMENT_METHODS)
.build()
button.initialize(options)
Expand Down
3 changes: 2 additions & 1 deletion android/src/main/java/com/boltreactnativesdk/GooglePayButtonViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class GooglePayButtonViewManager :

@ReactProp(name = "borderRadius", defaultFloat = 0f)
override fun setBorderRadius(view: GooglePayButtonView, borderRadius: Float) {
view.updateBorderRadius(PixelUtil.toPixelFromDIP(borderRadius))
val radiusPx = PixelUtil.toPixelFromDIP(borderRadius).toInt().coerceAtLeast(0)
view.updateBorderRadius(radiusPx)
}
}
1 change: 1 addition & 0 deletions example/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ const AddCardScreen = () => {
onComplete={handleGooglePayComplete}
onError={handleWalletError}
style={styles.walletButton}
borderRadius={25}
/>
)}

Expand Down
Loading