fix: use new docker tag on start rover script#175
Merged
Conversation
codeflight1
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
setup/start_rover.shscript to improve how the Docker image is referenced for starting thedisco-serverandweb-servercontainers. The main change is centralizing the Docker image name in a variable, making it easier to update and maintain.Docker image reference improvements:
ROVER_DOCKER_IMAGEvariable at the top ofstart_rover.shto define the Docker image name and tag (cprtsoftware/rover:latest).docker runcommands for both thedisco-serverandweb-servercontainers to use the newROVER_DOCKER_IMAGEvariable instead of hardcoding the image name. [1] [2]