Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/verify-recording.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ on:
type: choice
options: [blacksmith, hosted, both]
default: blacksmith
soak_secs:
description: "Adds the recording/soak/* cases at this length (seconds, at most 1800); set case_filter to recording/soak/* to run only them"
default: ""
schedule:
- cron: "41 3 * * *"
pull_request:
Expand Down Expand Up @@ -149,13 +152,14 @@ jobs:
matrix:
runner: ${{ fromJSON(needs.scope.outputs.runners) }}
runs-on: ${{ matrix.runner }}
timeout-minutes: 45
timeout-minutes: ${{ inputs.soak_secs != '' && 180 || 45 }}
env:
CAP_VERIFY_CAPTURE: display
CAP_VERIFY_REQUIRE_CAPTURE: "1"
CAP_VERIFY_TIER: ${{ needs.scope.outputs.tier }}
CAP_VERIFY_REPEAT: ${{ inputs.repeat || (github.event_name == 'schedule' && '3') || '1' }}
CAP_VERIFY_CASE: ${{ inputs.case_filter || '' }}
CAP_VERIFY_SOAK_SECS: ${{ inputs.soak_secs || '' }}
CAP_VERIFY_KEEP: ${{ inputs.keep_artifacts && '1' || '' }}
CAP_VERIFY_SCRATCH: ${{ github.workspace }}/verify-scratch
CAP_VERIFY_REPORT_DIR: ${{ github.workspace }}/verify-report
Expand Down
55 changes: 54 additions & 1 deletion crates/verify/tests/recording.rs
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ struct Spec {
}

fn specs() -> Vec<Spec> {
vec![
let mut specs = vec![
Spec {
id: "recording/studio-screen/fragmented",
tier: Tier::Fast,
Expand Down Expand Up @@ -289,6 +289,59 @@ fn specs() -> Vec<Spec> {
mic: true,
system_audio: true,
},
];
specs.extend(soak_specs());
specs
}

/// `CAP_VERIFY_SOAK_SECS`: at most 1800 s, because the microphone's 12-bit
/// marker index (one marker every 0.5 s) runs out past 34 minutes.
fn soak_specs() -> Vec<Spec> {
let Some(value) = std::env::var("CAP_VERIFY_SOAK_SECS")
.ok()
.filter(|v| !v.trim().is_empty())
else {
return vec![];
};
let seconds = value
.trim()
.parse::<f64>()
.ok()
.filter(|s| s.is_finite() && *s > 0.0)
.unwrap_or_else(|| {
panic!("CAP_VERIFY_SOAK_SECS={value:?} is not a positive number of seconds")
});
let seconds = seconds.min(1800.0);
vec![
Spec {
id: "recording/soak/studio-camera",
tier: Tier::Full,
mode: Mode::Studio {
fragmented: true,
camera: true,
},
seconds,
stimulus_fps: STIMULUS_FPS_30,
holds: vec![(seconds / 3.0, 3.0), (2.0 * seconds / 3.0, 10.0)],
Comment thread
richiemcilroy marked this conversation as resolved.
camera_drops_at: vec![],
gated: true,
mic_delay: 0.0,
mic: true,
system_audio: true,
},
Spec {
id: "recording/soak/instant",
tier: Tier::Full,
mode: Mode::Instant,
seconds,
stimulus_fps: STIMULUS_FPS_30,
holds: vec![(seconds / 2.0, 5.0)],
camera_drops_at: vec![],
gated: true,
mic_delay: 0.0,
mic: true,
system_audio: true,
},
]
}

Expand Down
Loading