Repository navigation
test(verify): opt-in 30-minute soak recordings - #2666
Merged
Merged
Conversation
Member
Author
|
Both addressed in dead545: a nonempty |
Member
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds opt-in 30-minute soak recordings to the real-capture oracle, for drift, frame loss and sync over a real session length.
What it adds
CAP_VERIFY_SOAK_SECS=<seconds>(at most 1800) adds two cases tocrates/verify/tests/recording.rs:recording/soak/studio-camera: gated Studio, fragmented, with camera, microphone and system audio, and two holds (3 s and 10 s).recording/soak/instant: gated Instant with microphone and system audio, and a 5 s hold.Verify recordinggains asoak_secsdispatch input, and the job timeout rises to 180 minutes when it is set. Without the variable nothing changes: the cases are not in any tier.First run
gh workflow run verify-recording.yml -f soak_secs=1800 -f case_filter='recording/soak/*' -f runners=blacksmith, run 38998821647:The macOS 26 Instant recording lost one isolated screen frame, within the miss budget; the others lost none. Analysis of a 30-minute recording takes 10 to 20 minutes per case on these runners.


Confidence Score: 5/5
The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found.Summary
Adds opt-in long recordings to check drift, frame loss, and audio/video sync.
Reviews (2) · Last reviewed commit: "test(verify): reject an invalid CAP_VERI..." · Reviewed by Greptile