Repository navigation
Sandbox gate: direct-kill fallback for MCP fixture reap - #141
Merged
Merged
Conversation
…dbox gate) The mcp-close test reaped its fixture server with a group kill only. In sealed RSI eval guests the group kill demonstrably misses (server alive 2s later, reap assert fails, baseline red) while direct pid kill — used by the descendant reap right below — works. Belt and suspenders: group kill first, then the server pid itself. No behavior change when the group kill lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSI baseline eval (rsi-20261013060952) failed at testMcpCloseRetainsFailedTransportForDispose:369 — 'test reaps the MCP server after restoring real signals', false !== true. Full 677KB trial output recovered via the output artifact (the 2KB preview hides it).
The test reaped its fixture server with kill(-serverPid) only. In sealed eval guests that group kill demonstrably misses (target alive 2s later) while direct pid kill — the descendant reap two lines below — works everywhere. Root cause of the group miss is unestablished (same-user SIGKILL to a live group should land; user/mount/worktree/network/uid all eliminated as factors by direct reproduction); the fallback closes it regardless.
Verified: suite green on host and in headlesscode-openshell-rsi:local; tsc clean; check-standards clean. Re-running improve after merge.