Skip to content

Sandbox gate: direct-kill fallback for MCP fixture reap #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w4ffl35 merged 1 commit into from
Oct 13, 2026
Merged

Sandbox gate: direct-kill fallback for MCP fixture reap #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/extensions/__tests__/runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,13 @@ async function testMcpCloseRetainsFailedTransportForDispose(workspaceRoot: strin
processRef.kill = originalKill
if (serverPid > 0) {
try { originalKill(-serverPid, "SIGKILL") } catch { /* fixture process group may already be gone */ }
// Fall back to the server pid itself: the group kill demonstrably
// misses in sealed guests (observed RSI eval failure), leaving the
// server alive for the reap check below. Direct kill matches the
// descendant reap; the pid is fixture-owned either way.
try {
originalKill(serverPid, "SIGKILL")
} catch { /* server may already be gone */ }
assert.equal(await processIsGone(serverPid), true, "test reaps the MCP server after restoring real signals")
}
if (descendantPid > 0) {
Expand Down
Loading