fix: Resolve IssueReporting consistently on Swift 6.2 - #10
Conversation
|
@codex review Please review the compiler conditional against the published Point-Free compatibility manifests. Swift 6.2 uses xctest-dynamic-overlay while Swift 6.4+ uses swift-issue-reporting; both identities cannot coexist because their targets have identical names. Existing CI tests both Apple platforms on Xcode 26.2. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Added narrow private metadata fix 3d0cd78 after exact crash diagnosis: all three retained iOS crashes resolve the generic closure-valued dependency associated type from Environment+CollectPreprocessor.swift:31. A nominal Sendable wrapper retains the public closure accessor types and existing behavior. All 66 local tests pass; hosted Xcode26.2 will validate the workaround. Please review API/source compatibility and correctness. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Swift 6.2 selects Point-Free compatibility manifests that use
xctest-dynamic-overlay, while Swift 6.4 usesswift-issue-reporting. This package previously requested the newer identity unconditionally, causing duplicateIssueReportingtargets on Xcode 26.2. Choose the same package identity as the dependency graph using a compiler conditional; public products remain unchanged.Restoring resolution exposed a Swift 6.2 crash when resolving the generic closure-valued preprocessor dependency's associated-type metadata. Retained iOS crash reports consistently point to
swift_getAssociatedTypeWitnessSlowImplcalled fromEnvironment+CollectPreprocessor.swift:31. Store that private closure in a nominal Sendable value while retaining the existing public getter/setter types and behavior. Add a direct dependency-read regression alongside the existing rendering tests.CI retains both platform results and exports test/crash diagnostics on failure. No test is disabled and the Xcode 26.2 requirement is unchanged.
Validation: all 66 tests in 15 suites pass locally on Swift 6.4; hosted Xcode 26.2 iOS/macOS tests are running for the metadata fix. The original main/0.1.1 CI failed before compilation, so it does not establish baseline runtime behavior. The metadata diagnosis comes from the repaired graph's actual crash stacks.
Required by CaptureContext/package-resources-cli#9. The consumer will pin the merged revision; no release tag is part of this change.