Skip to content

share cards: gauge benches drop "by p50" and p99 tails; benches 265/234 count scrapes as samples (were fees in dollars); WebP-as-PNG logos fixed - #2405

Merged
Flotapponnier merged 1 commit into
devfrom
fix/pf-share-card-samples
Sep 16, 2026
Merged

Flotapponnier merged 1 commit into
devfrom
fix/pf-share-card-samples

Conversation

@Flotapponnier

Copy link
Copy Markdown
Collaborator

Three points raised on the bench 265 share card:

  1. "Ranked by p50" but p99 under each bar. On a gauge bench p50 = p90 = p99 (one instant value), so the caption repeated the headline. isGaugeBench() now hides the p99 captions and the "by p50" wording on ranking, leaderboard, headline and compare cards. Latency benches render exactly as before.
  2. "124,240,646 samples". The spec's sample_size pointed at perp_protocol_fees_30d_usd, so the footer summed 30-day fees in dollars. Benches 265 and 234 now count scrapes (count_over_time(perp_protocol_health{...}[24h]), about 1,440 per row); methodology bullet says so. Takes effect on the next worker rebuild.
  3. "F (SynFu" clipped, blank logo. public/logos/synfutures.png (and 19 other files) were WebP bytes under a .png/.jpg name; Satori drew nothing. Converted in place. Bracketed tickers show the project name, long labels on dense cards shrink instead of clipping.

Rendered locally: ranking, compare (P/F) and cosmos-hub-rpc ranking (latency, unchanged).

🤖 Generated with Claude Code

https://claude.ai/code/session_01HJgbZCqjR4nvCfcJSzofbw

…65/234 count scrapes as samples, not fees in dollars

On perp-pf-ratio the ranking card read "Product ranking by p50" with
"p99 1.480x" under every bar, and the footer "124,240,646 samples": the
spec pointed sample_size at perp_protocol_fees_30d_usd, so the card
summed 30-day fees in dollars and called them samples. Both benches now
count scrapes of perp_protocol_health over 24h (about 1,440 per row),
and the methodology says so.

Cards: isGaugeBench() (every ranked row has p50 = p90 = p99) hides the
p99 captions, drops "by p50" from the ranking and leaderboard subtitles,
labels the compare panes with the metric name, and hides the p99 cell.
Latency benches unchanged.

Logos: 20 files under public/logos were WebP bytes with a .png/.jpg
name; Satori rendered them blank (the SynFutures column had an empty
gap). Converted to real PNG/JPEG, same names. Long labels on dense
ranking cards (SynFutures) shrink instead of clipping mid-word.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HJgbZCqjR4nvCfcJSzofbw
@Flotapponnier
Flotapponnier merged commit 59e15fe into dev Sep 16, 2026
1 check failed
@Flotapponnier
Flotapponnier deleted the fix/pf-share-card-samples branch September 16, 2026 15:57
Flotapponnier added a commit that referenced this pull request Sep 16, 2026
…65/234 count scrapes as samples, not fees in dollars (#2405) (#2406)

On perp-pf-ratio the ranking card read "Product ranking by p50" with
"p99 1.480x" under every bar, and the footer "124,240,646 samples": the
spec pointed sample_size at perp_protocol_fees_30d_usd, so the card
summed 30-day fees in dollars and called them samples. Both benches now
count scrapes of perp_protocol_health over 24h (about 1,440 per row),
and the methodology says so.

Cards: isGaugeBench() (every ranked row has p50 = p90 = p99) hides the
p99 captions, drops "by p50" from the ranking and leaderboard subtitles,
labels the compare panes with the metric name, and hides the p99 cell.
Latency benches unchanged.

Logos: 20 files under public/logos were WebP bytes with a .png/.jpg
name; Satori rendered them blank (the SynFutures column had an empty
gap). Converted to real PNG/JPEG, same names. Long labels on dense
ranking cards (SynFutures) shrink instead of clipping mid-word.

Claude-Session: https://claude.ai/code/session_01HJgbZCqjR4nvCfcJSzofbw



(cherry picked from commit 59e15fe)

Co-authored-by: Flotapponnier <florent@mobula.io>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants