Adopt the @effect/tsgo suggested rewrites - #249
Merged
Merged
Conversation
Rewrites every site tsc flags under preferSucceedSomeOrNone, mapSomeToAsSome, catchToOrElseSucceed, flatMapConditionalToFilterOrFail, multipleCatchTag, allOfMapToForEach and runOfExitToRunExit. Behaviour is unchanged. Four effectSucceedWithVoid sites are left as they are. Each returns a real T | undefined value, so Effect.void does not typecheck there.
projectForCwd and the rebuildNarrowSet session-id branch returned Effect.succeed(undefined) as a real value, which @effect/tsgo's effectSucceedWithVoid flags and whose Effect.void rewrite does not typecheck. They now return Option and unwrap only where they meet the session context and the subscription seeding.
GraemeF
added a commit
that referenced
this pull request
Sep 29, 2026
Sets `ignoreEffectSuggestionsInTscExitCode` to `false` in the tsconfig plugin entry. It defaults to `true`, so @effect/tsgo suggestions never failed `tsc --noEmit`. Now every Effect diagnostic at every severity fails the gate, so the suggestions cleared in #249 cannot come back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 7 with @effect/tsgo prints suggestion-level diagnostics on a clean typecheck. This rewrites the flagged code to the idiom each rule suggests, until the typecheck prints none. Behaviour is unchanged and no test assertion changes.
Most rewrites are
Effect.succeedSome/succeedNone,asSome,orElseSucceed,filterOrElse,catchTags,forEachandrunPromiseExit.Four
effectSucceedWithVoidsites returnedEffect.succeed(undefined)as a realT | undefinedvalue, where the suggestedEffect.voiddoes not typecheck. Those lookups,projectForCwdand the session id inrebuildNarrowSet, now returnOption. They unwrap only where they meet the session context and the subscription seeding, which still takeT | undefined. No rule is suppressed.