Repository navigation
feat: implement desktop chat composer and capability states - #71
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (12)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Found 16 test failures on Blacksmith runners: Failures
...and 6 more test failures. View all on Blacksmith
|
Mathis (echobt)
marked this pull request as ready for review
October 9, 2026 14:16
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Implement D03 local desktop Chat: no-provider action gating and provider navigation, keyboard model picker below the heading, eight-line composer using native CSS field sizing, elapsed busy strip and actual cancellation, sidebar/Cmd+N new-chat flow without duplicate content-header actions, direct capability empty states, and duplicate prompt-error suppression. Preserve the existing Code composer contract.
Targets
ux/desktop-01-kit(#70), not main.How to try it
bun run build && bun run start; open#/homein local mode. Fill 2,500 characters, add a provider, use model-chip arrow keys/Enter/Escape, send through a slow provider and press Stop. Direct links to canvas/search-results/deep-research/image-gen/share/temp-chat show the shared local capability state.Honest states
No-model sends/voice are disabled with aria-disabled. Add a provider navigates to provider setup. Direct local unsupported capabilities name the feature and offer provider setup. Existing session errors remain product-language cards.
Verification
Typecheck, ESLint, i18n audit and production build pass. Unit suite: 520 passed, one pre-existing conditional skip. Seven new registry/capability tests pass.
Real Electron Playwright: 1440/960 widths, light/dark themes, fresh profiles. Verified no-model controls/navigation, 2,500-character draft height 222 px with 20 px line-height, send bottom within 1 px, no textarea scrollbar arrows, nonintersecting picker with changed keyboard selection and Escape focus, timer 00:00 to 00:01, Stop in 43-100 ms, unchanged composer height 82 px, sidebar New chat/Cmd+N, six direct capability routes. Evidence:
/root/omo-herdr-wt/hermes-docs-qa-docs-attempt2/.omo/evidence/D03/final-results.jsonand PNGs.Full E2E: 88 passed, 156 failed. Not green. Shared
/tmpinode exhaustion plus legacy Chat route integration caused failures; focused recovery runs also blocked. No failing assertion was removed or weakened.Risk and rollback
Draft until parent applies the supplied shell patch outside D03's file allowlist: unavailable navigation remains visible and legacy
#/chatneeds shell dispatch after registry removal. Exact patch:/root/omo-herdr-wt/hermes-docs-qa-docs-attempt2/.omo/evidence/D03/parent-shell.apply_patch. Parent also owns required AGENTS.md update. Full DSK-07 not accepted until integration and rerun.Remote composer/native account capability parity remains an M11 integration dependency with M12 backend endpoints; M09/M10 not claimed integrated. No merge/deploy.
Attestation
AGENTS.mdand relevant.rules/files. Scoped changes follow them; parent-owned documentation/integration remains pending.