Install adapters on Node.js 22, run CI on Node.js 24, and record the adapter peer pin - #374
Merged
Merged
Conversation
checkout v7.0.1, setup-node v7.0.0, cache v6.1.0, upload-artifact v7.0.1 and repository-dispatch v4.0.1, each pinned by commit SHA. The v4/v3 pins target the deprecated Node 20 action runtime. None of the breaking changes apply: setup-node only auto-caches npm, and the publish job already strips the registry token placeholder that v7 no longer exports (#369)
Node.js 23 reached end of life in June 2025. Node.js 24 is the active LTS and satisfies every workspace's engines range; the full local gate passes on 24.20.0 (#369)
#233 decided that published adapters and Conformance peer on exactly their own Components release. That replaces the peer range sentence in ADR 0004, so it gets its own record, and ADR 0004's banner now points to it instead of calling the change a clarification. MIGRATION.md, which ships in the package, no longer says adapters declare >=4 <5 (#370)
setup-node v7 no longer exports a placeholder NODE_AUTH_TOKEN; it only
writes _authToken=${NODE_AUTH_TOKEN} to .npmrc, which the step still
removes (#369)
….lock The publish cache restored yarn.lock and was keyed only on package.json, so a lockfile-only change hit a stale entry that overwrote the checked-out lockfile, and the job could publish a dependency graph CI never tested. It now uses the build jobs' key and leaves yarn.lock to the checkout (#369)
They declared >=23.0.0, so npm and pnpm with engine-strict refused to install them on Node.js 22, a maintained LTS release, although the core package declares no engines and nothing needs 23. Each adapter builds and passes its consumer check on Node.js 22, and Conformance passes its CI there (#371)
One leg per adapter installs the packed adapter with npm on Node.js 22 and engine-strict on, so an engines range that excludes the oldest supported Node.js, or an adapter that fails there, fails CI. A planted >=23 range failed this check locally with EBADENGINE (#371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renderer adapters and Conformance now install on Node.js 22, and the migration guide describes how adapter versions pair with
@cratis/components.Fixed
@cratis/components.mui,@cratis/components.primereact,@cratis/components.primereact10and@cratis/components.conformancedeclaredengines.node >=23.0.0, so npm and pnpm withengine-strictrefused to install them on Node.js 22, a maintained LTS release. They now declare>=22.0.0. CI installs each adapter on Node.js 22 withengine-stricton. (Decide the supported Node.js range for published packages #371)MIGRATION.mdsaid the adapters declare a@cratis/components >=4 <5peer range. Each published adapter and Conformance release requires exactly the@cratis/componentsversion it was released with, so install and upgrade them together. (Note the exact adapter peer pin in ADR 0004 #370)