Skip to content

Install adapters on Node.js 22, run CI on Node.js 24, and record the adapter peer pin #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woksin merged 9 commits into from
Sep 29, 2026
Merged

Install adapters on Node.js 22, run CI on Node.js 24, and record the adapter peer pin #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a476126
Pin workflow actions to their Node 24 runtime majors
woksin Sep 29, 2026
7b0e5c5
Build, test and publish on Node.js 24 LTS
woksin Sep 29, 2026
ded62c5
Note in ADR 0004 that published adapters pin their exact release
woksin Sep 29, 2026
08778cb
Record the exact adapter peer pin as ADR 0006
woksin Sep 29, 2026
6dcab18
Describe what setup-node v7 writes in the publish OIDC step
woksin Sep 29, 2026
b627d9c
Key the publish job's yarn cache like the build and stop caching yarn…
woksin Sep 29, 2026
3685c96
Accept Node.js 22 in the adapters' and Conformance's engines
woksin Sep 29, 2026
012c974
Verify each renderer adapter on Node.js 22 with engine-strict
woksin Sep 29, 2026
ff6b184
Merge remote-tracking branch 'origin/main' into fix/node-engines-371
woksin Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 76 additions & 57 deletions .github/workflows/javascript-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,17 +81,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand Down Expand Up @@ -149,17 +149,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand Down Expand Up @@ -198,17 +198,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand Down Expand Up @@ -258,17 +258,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand Down Expand Up @@ -336,17 +336,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand All @@ -366,7 +366,7 @@ jobs:
--output "${{ runner.temp }}/components-v4-release-evidence"

- name: Upload release evidence
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: components-v4-release-evidence-${{ github.sha }}
path: |
Expand Down Expand Up @@ -398,17 +398,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand Down Expand Up @@ -448,17 +448,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand All @@ -484,7 +484,7 @@ jobs:

- name: Upload verify-public-types report
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: verify-public-types-report-ts${{ matrix.typescript }}
path: ${{ runner.temp }}/verify-public-types-report.json
Expand All @@ -502,17 +502,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand All @@ -536,7 +536,7 @@ jobs:

- name: Upload verify-package-graph report
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: verify-package-graph-report
path: ${{ runner.temp }}/verify-package-graph-report.json
Expand All @@ -552,17 +552,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand Down Expand Up @@ -594,17 +594,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand Down Expand Up @@ -637,17 +637,17 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: yarn-cache
with:
path: |
Expand Down Expand Up @@ -679,14 +679,14 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- name: Yarn install
Expand Down Expand Up @@ -754,14 +754,14 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x
registry-url: 'https://registry.npmjs.org'

- name: Enable Corepack
Expand Down Expand Up @@ -836,7 +836,7 @@ jobs:
yarn node verify-peers.mjs

verify-renderer-adapters:
name: Renderer adapter (${{ matrix.adapter }}, ${{ matrix.boundary }}, ${{ matrix.manager }})
name: Renderer adapter (${{ matrix.adapter }}, ${{ matrix.boundary }}, ${{ matrix.manager }}, Node ${{ matrix.node }})
runs-on: ubuntu-latest
timeout-minutes: 25
strategy:
Expand All @@ -845,17 +845,36 @@ jobs:
adapter: [mui, primereact11, primereact10]
boundary: [minimum, current]
manager: [npm, pnpm, yarn-pnp]
node: [24.x]
# The oldest Node.js the published packages declare in engines. npm with
# engine-strict refuses to install a package whose engines exclude the running
# Node.js, so these legs prove both the declared range and that the adapter works.
include:
- adapter: mui
boundary: current
manager: npm
node: 22.x
- adapter: primereact11
boundary: current
manager: npm
node: 22.x
- adapter: primereact10
boundary: current
manager: npm
node: 22.x
env:
npm_config_engine_strict: ${{ matrix.node == '22.x' }}

steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: ${{ matrix.node }}
registry-url: 'https://registry.npmjs.org'

- name: Enable Corepack
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/markdown-verification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ jobs:
timeout-minutes: 15
steps:
- name: Checkout code
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

- name: Setup node
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 23.x
node-version: 24.x

# Run the same entry point contributors use locally so linting,
# authoring validation, and local-link checks cannot drift apart.
Expand Down
Loading
Loading