Repository navigation
Regenerate the reports from run 20261019_225524 as reconciled on main after #719 (#720) - #721
Merged
Merged
Conversation
… after #719 (#720) `make all-reports RUN_DIR=output/anvil/20261019_225524 PREVIOUS=output/anvil/20261019_084533`. Three reports change, each from #719's SGDP donors: - reconcile report: reconciled by fa826ed, the translation table's new sha256 (SGDP's M/F rows); no file-level number moves (the 16 artifacts are identical). - rules report: 190 rules and 18 sample and donor rules; 3,668 donor records; sgdp_id 104, hgdp_cell_line 130, phenotypic_sex.sgdp_m 174 and sgdp_f 101, coriell_cell_line_or_dna +18 (the new Coriell NA donors). - review queue: SGDP's 129 populations listed as unreviewed external values. Coverage, consistency, unprocessable and validation reports are unchanged. Closes #720. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VF7tbFa5ZTmYWZ6JWKiBBS
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The supplied report changes match the stated scope, and the alleged missing HTML populations are present.
No open issues 🎉
What changed in this PR
Refreshes generated reports for run 20261019_225524 after #719’s SGDP donor import, addressing #720.
Changes:
- Updates reconciliation provenance and translation-table identity.
- Reports 3,668 donors and the new SGDP-related rules.
- Adds 129 unreviewed SGDP populations to both queue formats.
| File | Description |
|---|---|
| docs/rules-report.md | Updates donor totals, rules, and usage counts. |
| docs/review-queue.html | Adds SGDP populations and sex mappings. |
| docs/review-queue-report.md | Reflects the same queue additions in Markdown. |
| docs/reconcile-report.md | Updates reconciliation commit and comparison metadata. |
Review effort: Balanced
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #720.
What changed
I regenerated the reports from run
20261019_225524as reconciled on main after #719 (fa826ed), comparing with20261019_084533as before:Three reports change. Each change comes from #719's SGDP donors:
reconcile-report.md,reconcile-dashboard.html):fa826ed;M/Frows), so the comparison line now says "a different translation table";rules-report.md,rules-dashboard.html):sgdp_id104,hgdp_cell_line130,phenotypic_sex.sgdp_m174 andphenotypic_sex.sgdp_f101. 174 + 101 = 275, one sex claim on each SGDP donor record: 252 new (130hgdp, 104sgdp, 18coriell) and the 23 existing 1000 Genomes donors, measured on the reconciled run;coriell_cell_line_or_dna+18, which is the 18 new CoriellNA…donors.review-queue-report.md,review-queue.html): SGDP's 129 populations are listed as unreviewed external values. That section said "No unreviewed values" before.The coverage, consistency, unprocessable and validation reports regenerated byte-identical.
Why
#719 imported SGDP's donors and reconciled the shared run again on main. The run's file records didn't change, but its donor and sample records did, and the code gained two identifier rules. The committed reports still showed the run as #716 left it.
Assumptions I made
20261019_084533, as Read each NIA_CARD fast5's sample from its first 64 KiB (#605) #716 did, so the reconcile report's change table spans Read each NIA_CARD fast5's sample from its HDF5 attributes (cross-check with #604's folder join when it lands) #605 and SGDP donors for ANVIL_T2T_CHRY, with transitive synonyms (#559) #719 together.5841265, Read each NIA_CARD fast5's sample from its HDF5 attributes (cross-check with #604's folder join when it lands) #605's branch commit, because Regenerate the reports from run 20261019_225524 as reconciled on main after #719 #720 only reconciles. That commit isn't on main, but GitHub keeps it underrefs/pull/716/head, and its readings were measured equal to main's. Classifying the corpus again on main is a separate decision that wasn't taken.same_donor_asjoin. It keys records rather than claiming values, and each synonym cites an identifier rule the report already lists.How to verify
#720's definition of done:
docs/that reads an AnVIL run names20261019_225524, and any report reading the run's reconcile provenance showsfa826ed.grep -l 20261019_225524 docs/*.mdlists the reconcile, rules, consistency and unprocessable reports. The coverage report names the run by its start time, "Classification run: 2026-10-19 22:55:24".docs/reconcile-report.mdreads "Reconciled by: commit fa826ed".sgdp_idandhgdp_cell_lineidentifier rules, and shows the new donor total where it counts donor records.In
docs/rules-report.md, the identifier-rule table hassgdp_id(104) andhgdp_cell_line(130), and the header reads "3,668 donor records".make all-reportscommand above on main after SGDP donors for ANVIL_T2T_CHRY, with transitive synonyms (#559) #719:git statusshould then show no changes.🤖 Generated with Claude Code
https://claude.ai/code/session_01VF7tbFa5ZTmYWZ6JWKiBBS
🐦 Built with cc-claude-tools