Draft
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~1f3186fc66, baseline=1.60.0-SNAPSHOT~6fdb8c86a8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063524
Total [baseline] (10.788 s) : 0, 10788227
Agent [candidate] (1.075 s) : 0, 1074951
Total [candidate] (10.88 s) : 0, 10879789
section appsec
Agent [baseline] (1.238 s) : 0, 1238138
Total [baseline] (10.913 s) : 0, 10913120
Agent [candidate] (1.246 s) : 0, 1246386
Total [candidate] (11.04 s) : 0, 11039579
section iast
Agent [baseline] (1.23 s) : 0, 1229516
Total [baseline] (11.2 s) : 0, 11200156
Agent [candidate] (1.229 s) : 0, 1228871
Total [candidate] (11.162 s) : 0, 11162321
section profiling
Agent [baseline] (1.198 s) : 0, 1198144
Total [baseline] (11.017 s) : 0, 11016806
Agent [candidate] (1.192 s) : 0, 1192345
Total [candidate] (10.979 s) : 0, 10979111
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~1f3186fc66, baseline=1.60.0-SNAPSHOT~6fdb8c86a8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (627.955 ms) : 0, 627955
BytebuddyAgent [candidate] (634.796 ms) : 0, 634796
AgentMeter [baseline] (28.821 ms) : 0, 28821
AgentMeter [candidate] (29.132 ms) : 0, 29132
GlobalTracer [baseline] (257.404 ms) : 0, 257404
GlobalTracer [candidate] (259.59 ms) : 0, 259590
AppSec [baseline] (32.809 ms) : 0, 32809
AppSec [candidate] (33.168 ms) : 0, 33168
Debugger [baseline] (61.849 ms) : 0, 61849
Debugger [candidate] (65.513 ms) : 0, 65513
Remote Config [baseline] (613.474 µs) : 0, 613
Remote Config [candidate] (619.214 µs) : 0, 619
Telemetry [baseline] (11.42 ms) : 0, 11420
Telemetry [candidate] (10.756 ms) : 0, 10756
Flare Poller [baseline] (6.16 ms) : 0, 6160
Flare Poller [candidate] (4.639 ms) : 0, 4639
section appsec
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (657.579 ms) : 0, 657579
BytebuddyAgent [candidate] (663.038 ms) : 0, 663038
AgentMeter [baseline] (11.894 ms) : 0, 11894
AgentMeter [candidate] (11.947 ms) : 0, 11947
GlobalTracer [baseline] (258.651 ms) : 0, 258651
GlobalTracer [candidate] (260.262 ms) : 0, 260262
IAST [baseline] (25.21 ms) : 0, 25210
IAST [candidate] (25.344 ms) : 0, 25344
AppSec [baseline] (167.752 ms) : 0, 167752
AppSec [candidate] (168.497 ms) : 0, 168497
Debugger [baseline] (67.208 ms) : 0, 67208
Debugger [candidate] (67.16 ms) : 0, 67160
Remote Config [baseline] (676.112 µs) : 0, 676
Remote Config [candidate] (664.759 µs) : 0, 665
Telemetry [baseline] (9.13 ms) : 0, 9130
Telemetry [candidate] (9.211 ms) : 0, 9211
Flare Poller [baseline] (3.624 ms) : 0, 3624
Flare Poller [candidate] (3.582 ms) : 0, 3582
section iast
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (795.099 ms) : 0, 795099
BytebuddyAgent [candidate] (794.089 ms) : 0, 794089
AgentMeter [baseline] (11.235 ms) : 0, 11235
AgentMeter [candidate] (11.227 ms) : 0, 11227
GlobalTracer [baseline] (247.422 ms) : 0, 247422
GlobalTracer [candidate] (247.379 ms) : 0, 247379
IAST [baseline] (26.95 ms) : 0, 26950
IAST [candidate] (26.95 ms) : 0, 26950
AppSec [baseline] (33.804 ms) : 0, 33804
AppSec [candidate] (34.513 ms) : 0, 34513
Debugger [baseline] (65.816 ms) : 0, 65816
Debugger [candidate] (65.792 ms) : 0, 65792
Remote Config [baseline] (542.053 µs) : 0, 542
Remote Config [candidate] (538.372 µs) : 0, 538
Telemetry [baseline] (8.751 ms) : 0, 8751
Telemetry [candidate] (8.641 ms) : 0, 8641
Flare Poller [baseline] (3.482 ms) : 0, 3482
Flare Poller [candidate] (3.433 ms) : 0, 3433
section profiling
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (687.646 ms) : 0, 687646
BytebuddyAgent [candidate] (682.394 ms) : 0, 682394
AgentMeter [baseline] (8.85 ms) : 0, 8850
AgentMeter [candidate] (8.815 ms) : 0, 8815
GlobalTracer [baseline] (216.776 ms) : 0, 216776
GlobalTracer [candidate] (217.337 ms) : 0, 217337
AppSec [baseline] (32.601 ms) : 0, 32601
AppSec [candidate] (32.882 ms) : 0, 32882
Debugger [baseline] (67.645 ms) : 0, 67645
Debugger [candidate] (67.55 ms) : 0, 67550
Remote Config [baseline] (602.919 µs) : 0, 603
Remote Config [candidate] (605.617 µs) : 0, 606
Telemetry [baseline] (8.888 ms) : 0, 8888
Telemetry [candidate] (8.944 ms) : 0, 8944
Flare Poller [baseline] (3.788 ms) : 0, 3788
Flare Poller [candidate] (3.792 ms) : 0, 3792
ProfilingAgent [baseline] (99.82 ms) : 0, 99820
ProfilingAgent [candidate] (99.005 ms) : 0, 99005
Profiling [baseline] (100.408 ms) : 0, 100408
Profiling [candidate] (99.585 ms) : 0, 99585
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~1f3186fc66, baseline=1.60.0-SNAPSHOT~6fdb8c86a8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1073233
Total [baseline] (8.749 s) : 0, 8748827
Agent [candidate] (1.063 s) : 0, 1062929
Total [candidate] (8.732 s) : 0, 8732158
section iast
Agent [baseline] (1.231 s) : 0, 1230905
Total [baseline] (9.329 s) : 0, 9328560
Agent [candidate] (1.242 s) : 0, 1241705
Total [candidate] (9.35 s) : 0, 9350147
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~1f3186fc66, baseline=1.60.0-SNAPSHOT~6fdb8c86a8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (634.653 ms) : 0, 634653
BytebuddyAgent [candidate] (628.709 ms) : 0, 628709
AgentMeter [baseline] (29.037 ms) : 0, 29037
AgentMeter [candidate] (28.922 ms) : 0, 28922
GlobalTracer [baseline] (259.224 ms) : 0, 259224
GlobalTracer [candidate] (258.062 ms) : 0, 258062
AppSec [baseline] (33.21 ms) : 0, 33210
AppSec [candidate] (32.764 ms) : 0, 32764
Debugger [baseline] (61.065 ms) : 0, 61065
Debugger [candidate] (62.757 ms) : 0, 62757
Remote Config [baseline] (635.271 µs) : 0, 635
Remote Config [candidate] (610.964 µs) : 0, 611
Telemetry [baseline] (13.985 ms) : 0, 13985
Telemetry [candidate] (9.174 ms) : 0, 9174
Flare Poller [baseline] (4.619 ms) : 0, 4619
Flare Poller [candidate] (5.378 ms) : 0, 5378
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (795.815 ms) : 0, 795815
BytebuddyAgent [candidate] (804.881 ms) : 0, 804881
AgentMeter [baseline] (11.274 ms) : 0, 11274
AgentMeter [candidate] (11.518 ms) : 0, 11518
GlobalTracer [baseline] (247.862 ms) : 0, 247862
GlobalTracer [candidate] (248.932 ms) : 0, 248932
IAST [baseline] (26.972 ms) : 0, 26972
IAST [candidate] (27.081 ms) : 0, 27081
AppSec [baseline] (34.113 ms) : 0, 34113
AppSec [candidate] (35.018 ms) : 0, 35018
Debugger [baseline] (65.821 ms) : 0, 65821
Debugger [candidate] (64.993 ms) : 0, 64993
Remote Config [baseline] (544.141 µs) : 0, 544
Remote Config [candidate] (536.132 µs) : 0, 536
Telemetry [baseline] (8.643 ms) : 0, 8643
Telemetry [candidate] (8.61 ms) : 0, 8610
Flare Poller [baseline] (3.468 ms) : 0, 3468
Flare Poller [candidate] (3.455 ms) : 0, 3455
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~1f3186fc66, baseline=1.60.0-SNAPSHOT~6fdb8c86a8
dateFormat X
axisFormat %s
section baseline
no_agent (1.175 ms) : 1163, 1186
. : milestone, 1175,
iast (3.11 ms) : 3069, 3150
. : milestone, 3110,
iast_FULL (5.597 ms) : 5541, 5652
. : milestone, 5597,
iast_GLOBAL (3.502 ms) : 3443, 3562
. : milestone, 3502,
profiling (2.032 ms) : 2014, 2049
. : milestone, 2032,
tracing (1.805 ms) : 1790, 1819
. : milestone, 1805,
section candidate
no_agent (1.179 ms) : 1167, 1191
. : milestone, 1179,
iast (3.158 ms) : 3114, 3201
. : milestone, 3158,
iast_FULL (5.862 ms) : 5803, 5922
. : milestone, 5862,
iast_GLOBAL (3.459 ms) : 3410, 3508
. : milestone, 3459,
profiling (2.361 ms) : 2338, 2385
. : milestone, 2361,
tracing (1.765 ms) : 1751, 1779
. : milestone, 1765,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~1f3186fc66, baseline=1.60.0-SNAPSHOT~6fdb8c86a8
dateFormat X
axisFormat %s
section baseline
no_agent (17.913 ms) : 17730, 18096
. : milestone, 17913,
appsec (18.534 ms) : 18346, 18723
. : milestone, 18534,
code_origins (17.9 ms) : 17725, 18076
. : milestone, 17900,
iast (17.686 ms) : 17507, 17865
. : milestone, 17686,
profiling (18.734 ms) : 18549, 18920
. : milestone, 18734,
tracing (17.659 ms) : 17483, 17835
. : milestone, 17659,
section candidate
no_agent (17.941 ms) : 17760, 18122
. : milestone, 17941,
appsec (18.3 ms) : 18114, 18486
. : milestone, 18300,
code_origins (19.063 ms) : 18866, 19260
. : milestone, 19063,
iast (17.605 ms) : 17427, 17783
. : milestone, 17605,
profiling (19.068 ms) : 18877, 19260
. : milestone, 19068,
tracing (17.649 ms) : 17474, 17824
. : milestone, 17649,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~1f3186fc66, baseline=1.60.0-SNAPSHOT~6fdb8c86a8
dateFormat X
axisFormat %s
section baseline
no_agent (15.084 s) : 15084000, 15084000
. : milestone, 15084000,
appsec (15.129 s) : 15129000, 15129000
. : milestone, 15129000,
iast (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
. : milestone, 17885000,
profiling (14.809 s) : 14809000, 14809000
. : milestone, 14809000,
tracing (14.775 s) : 14775000, 14775000
. : milestone, 14775000,
section candidate
no_agent (14.752 s) : 14752000, 14752000
. : milestone, 14752000,
appsec (14.808 s) : 14808000, 14808000
. : milestone, 14808000,
iast (18.217 s) : 18217000, 18217000
. : milestone, 18217000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
tracing (14.729 s) : 14729000, 14729000
. : milestone, 14729000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~1f3186fc66, baseline=1.60.0-SNAPSHOT~6fdb8c86a8
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1496
. : milestone, 1484,
appsec (2.529 ms) : 2473, 2584
. : milestone, 2529,
iast (2.274 ms) : 2204, 2344
. : milestone, 2274,
iast_GLOBAL (2.321 ms) : 2250, 2391
. : milestone, 2321,
profiling (2.093 ms) : 2038, 2148
. : milestone, 2093,
tracing (2.074 ms) : 2021, 2128
. : milestone, 2074,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.523 ms) : 2468, 2579
. : milestone, 2523,
iast (2.277 ms) : 2206, 2347
. : milestone, 2277,
iast_GLOBAL (2.315 ms) : 2245, 2386
. : milestone, 2315,
profiling (2.119 ms) : 2062, 2176
. : milestone, 2119,
tracing (2.096 ms) : 2041, 2150
. : milestone, 2096,
|
Adapt J9JavacoreParser and tests to updated crash tracking DTOs: - SigInfo now requires 5 parameters (added code, action, address) - StackFrame now requires 7 parameters (added buildId, buildIdType, fileType, relativeAddress) - ProcInfo.pid changed from String to int - Test assertions updated for field rename (file -> path) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Integrate BuildIdCollector into J9JavacoreParser to extract build IDs from native libraries in crash reports, matching HotspotCrashLogParser: - Added BuildIdCollector for async build ID extraction from ELF binaries - Modified parseNativeStackFrame() to collect library names from native frames - Enriched stack frames with build IDs, file types, and build ID types - Added 5-second timeout for build ID collection completion J9 javacores include native stack frames like [libcrash.so+0x1d7d] which now get enriched with GNU build IDs when available, improving crash symbolication and debugging capabilities. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code review fixes: - Extract relative address from native stack frames ([lib+0xoffset]) - Add safe integer parsing for PID to handle malformed javacores Matches HotspotCrashLogParser patterns for consistency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove obsolete comment about J9 handling from Agent.java - Separate J9 (javacore) and HotSpot (hs_err) config paths clearly - Update javadoc to reflect actual initialization order - Remove proactive script deployment when -Xdump not configured J9 VMs use javacore format exclusively, not hs_err, so config should only include javacore_path for J9 environments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds crash tracking support for J9/OpenJ9 JVMs (IBM Semeru, Eclipse OpenJ9). This includes:
J9JavacoreParserto parse J9 javacore dump filesInitializer.java-Xdump:java:file=Motivation
Previously, crash tracking only supported HotSpot-based JVMs. J9/OpenJ9 JVMs use a different crash dump format (javacore files) and require manual configuration of
-Xdump:toolsince this cannot be set at runtime. This PR extends crash tracking to support J9/OpenJ9, enabling crash reporting for users running on IBM Semeru or Eclipse OpenJ9.Additional Notes
-Xdump:tool:events=gpf+abort,exec=...)dd-java-agent/agent-crashtracking/doc/manual-crash-tracking-setup.mdContributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROF-XXXX]