Fix flaky test exception in HttpServerTest by janhavis · Pull Request #11164 · DataDog/dd-trace-java

janhavis · 2026-04-20T15:18:37Z

What Does This Do

Fixing test exception • View in Test Optimization • Questions? Ask in #code-gen-flaky-tests

This PR fixes a flaky test test exception in Pekko HTTP instrumentation tests by ensuring that the HTTP response is always closed in the base HttpServerTest class.

Motivation

The test test exception was intermittently failing with a TimeoutException waiting for traces, particularly in HTTP/2 scenarios. This is likely caused by the response body not being consumed when testExceptionBody() is false, which can prevent the server from finishing the request/response cycle and thus prevent the server span from being closed. In HTTP/2, unconsumed streams can lead to such issues due to flow control.

Additional Notes

Added response.close() to test exception, test error, and test notFound in HttpServerTest.groovy for cases where the body is not consumed.
Removed the @Flaky annotation for test exception in HttpServerTest.groovy as this fix should resolve the underlying issue.

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type:bug and inst:pekko-http labels
Avoid using linking keywords
Update the CODEOWNERS file (N/A)
Update public documentation (N/A)

PR by Bits - View session in Datadog

Comment @DataDog to request changes

DD_C0320J Co-authored-by: janhavis <janhavi.sahasrabuddhe@gmail.com>

datadog-official · 2026-04-20T15:18:39Z

View session in Datadog

Bits Dev status: ✅ Done

CI Auto-fix: Disabled | Enable

Comment @DataDog to request changes

datadog-official · 2026-04-20T15:18:43Z

I can only run on private repositories.

github-actions · 2026-04-20T15:18:49Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

PerfectSlayer

❔ question: ‏Are there some other methods that need would response closing?
That could be a good opportunity to fix it once for all because I don't think it's the first time we come up with this kind of fix.

janhavis · 2026-04-20T15:40:40Z

❔ question: ‏Are there some other methods that need would response closing? That could be a good opportunity to fix it once for all because I don't think it's the first time we come up with this kind of fix.

Potentially. I will take a look.

pr-commenter · 2026-04-20T16:06:25Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	dd/fix/pekko-http-flaky-test-exception
git_commit_date	1776707964	1776715214
git_commit_sha	`6e28457`	`5a02e8b`
release_version	1.62.0-SNAPSHOT~6e28457d70	1.62.0-SNAPSHOT~5a02e8b8f4

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1776717218	1776717218
ci_job_id	1612783169	1612783169
ci_pipeline_id	108653713	108653713
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-zklu6yvb 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-zklu6yvb 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~5a02e8b8f4, baseline=1.62.0-SNAPSHOT~6e28457d70

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057561
Total [baseline] (11.055 s) : 0, 11055036
Agent [candidate] (1.058 s) : 0, 1058405
Total [candidate] (11.073 s) : 0, 11072875
section appsec
Agent [baseline] (1.261 s) : 0, 1261460
Total [baseline] (10.995 s) : 0, 10994699
Agent [candidate] (1.268 s) : 0, 1268374
Total [candidate] (10.961 s) : 0, 10960590
section iast
Agent [baseline] (1.231 s) : 0, 1230939
Total [baseline] (11.235 s) : 0, 11235466
Agent [candidate] (1.232 s) : 0, 1232475
Total [candidate] (11.284 s) : 0, 11283653
section profiling
Agent [baseline] (1.193 s) : 0, 1193482
Total [baseline] (11.045 s) : 0, 11045203
Agent [candidate] (1.192 s) : 0, 1192447
Total [candidate] (11.024 s) : 0, 11024408

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.058 s	-
Agent	appsec	1.261 s	203.898 ms (19.3%)
Agent	iast	1.231 s	173.378 ms (16.4%)
Agent	profiling	1.193 s	135.921 ms (12.9%)
Total	tracing	11.055 s	-
Total	appsec	10.995 s	-60.337 ms (-0.5%)
Total	iast	11.235 s	180.43 ms (1.6%)
Total	profiling	11.045 s	-9.833 ms (-0.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.058 s	-
Agent	appsec	1.268 s	209.969 ms (19.8%)
Agent	iast	1.232 s	174.07 ms (16.4%)
Agent	profiling	1.192 s	134.041 ms (12.7%)
Total	tracing	11.073 s	-
Total	appsec	10.961 s	-112.284 ms (-1.0%)
Total	iast	11.284 s	210.778 ms (1.9%)
Total	profiling	11.024 s	-48.467 ms (-0.4%)

gantt
    title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~5a02e8b8f4, baseline=1.62.0-SNAPSHOT~6e28457d70

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (632.568 ms) : 0, 632568
BytebuddyAgent [candidate] (633.501 ms) : 0, 633501
AgentMeter [baseline] (29.51 ms) : 0, 29510
AgentMeter [candidate] (29.526 ms) : 0, 29526
GlobalTracer [baseline] (248.445 ms) : 0, 248445
GlobalTracer [candidate] (248.308 ms) : 0, 248308
AppSec [baseline] (32.322 ms) : 0, 32322
AppSec [candidate] (32.331 ms) : 0, 32331
Debugger [baseline] (59.697 ms) : 0, 59697
Debugger [candidate] (59.725 ms) : 0, 59725
Remote Config [baseline] (600.092 µs) : 0, 600
Remote Config [candidate] (600.615 µs) : 0, 601
Telemetry [baseline] (8.004 ms) : 0, 8004
Telemetry [candidate] (7.997 ms) : 0, 7997
Flare Poller [baseline] (8.96 ms) : 0, 8960
Flare Poller [candidate] (9.099 ms) : 0, 9099
section appsec
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (674.567 ms) : 0, 674567
BytebuddyAgent [candidate] (677.983 ms) : 0, 677983
AgentMeter [baseline] (12.154 ms) : 0, 12154
AgentMeter [candidate] (12.202 ms) : 0, 12202
GlobalTracer [baseline] (248.921 ms) : 0, 248921
GlobalTracer [candidate] (249.852 ms) : 0, 249852
IAST [baseline] (24.363 ms) : 0, 24363
IAST [candidate] (24.498 ms) : 0, 24498
AppSec [baseline] (186.148 ms) : 0, 186148
AppSec [candidate] (187.743 ms) : 0, 187743
Debugger [baseline] (65.75 ms) : 0, 65750
Debugger [candidate] (66.426 ms) : 0, 66426
Remote Config [baseline] (589.581 µs) : 0, 590
Remote Config [candidate] (578.488 µs) : 0, 578
Telemetry [baseline] (7.886 ms) : 0, 7886
Telemetry [candidate] (7.983 ms) : 0, 7983
Flare Poller [baseline] (3.479 ms) : 0, 3479
Flare Poller [candidate] (3.537 ms) : 0, 3537
section iast
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (808.627 ms) : 0, 808627
BytebuddyAgent [candidate] (810.404 ms) : 0, 810404
AgentMeter [baseline] (11.389 ms) : 0, 11389
AgentMeter [candidate] (11.439 ms) : 0, 11439
GlobalTracer [baseline] (238.888 ms) : 0, 238888
GlobalTracer [candidate] (239.037 ms) : 0, 239037
IAST [baseline] (29.132 ms) : 0, 29132
IAST [candidate] (31.574 ms) : 0, 31574
AppSec [baseline] (29.302 ms) : 0, 29302
AppSec [candidate] (26.518 ms) : 0, 26518
Debugger [baseline] (63.719 ms) : 0, 63719
Debugger [candidate] (64.585 ms) : 0, 64585
Remote Config [baseline] (532.724 µs) : 0, 533
Remote Config [candidate] (529.569 µs) : 0, 530
Telemetry [baseline] (7.73 ms) : 0, 7730
Telemetry [candidate] (7.726 ms) : 0, 7726
Flare Poller [baseline] (3.423 ms) : 0, 3423
Flare Poller [candidate] (3.391 ms) : 0, 3391
section profiling
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (697.409 ms) : 0, 697409
BytebuddyAgent [candidate] (696.717 ms) : 0, 696717
AgentMeter [baseline] (9.278 ms) : 0, 9278
AgentMeter [candidate] (9.275 ms) : 0, 9275
GlobalTracer [baseline] (208.333 ms) : 0, 208333
GlobalTracer [candidate] (208.442 ms) : 0, 208442
AppSec [baseline] (33.16 ms) : 0, 33160
AppSec [candidate] (33.123 ms) : 0, 33123
Debugger [baseline] (66.162 ms) : 0, 66162
Debugger [candidate] (66.14 ms) : 0, 66140
Remote Config [baseline] (596.834 µs) : 0, 597
Remote Config [candidate] (596.701 µs) : 0, 597
Telemetry [baseline] (7.795 ms) : 0, 7795
Telemetry [candidate] (7.782 ms) : 0, 7782
Flare Poller [baseline] (3.528 ms) : 0, 3528
Flare Poller [candidate] (3.511 ms) : 0, 3511
ProfilingAgent [baseline] (94.254 ms) : 0, 94254
ProfilingAgent [candidate] (94.03 ms) : 0, 94030
Profiling [baseline] (94.822 ms) : 0, 94822
Profiling [candidate] (94.588 ms) : 0, 94588

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~5a02e8b8f4, baseline=1.62.0-SNAPSHOT~6e28457d70

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054267
Total [baseline] (8.816 s) : 0, 8815775
Agent [candidate] (1.062 s) : 0, 1062103
Total [candidate] (8.889 s) : 0, 8888946
section iast
Agent [baseline] (1.229 s) : 0, 1229439
Total [baseline] (9.589 s) : 0, 9589038
Agent [candidate] (1.245 s) : 0, 1244804
Total [candidate] (9.564 s) : 0, 9564036

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	iast	1.229 s	175.172 ms (16.6%)
Total	tracing	8.816 s	-
Total	iast	9.589 s	773.263 ms (8.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	iast	1.245 s	182.701 ms (17.2%)
Total	tracing	8.889 s	-
Total	iast	9.564 s	675.091 ms (7.6%)

gantt
    title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~5a02e8b8f4, baseline=1.62.0-SNAPSHOT~6e28457d70

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.229 ms) : 0, 1229
BytebuddyAgent [baseline] (633.079 ms) : 0, 633079
BytebuddyAgent [candidate] (637.925 ms) : 0, 637925
AgentMeter [baseline] (29.531 ms) : 0, 29531
AgentMeter [candidate] (29.485 ms) : 0, 29485
GlobalTracer [baseline] (248.525 ms) : 0, 248525
GlobalTracer [candidate] (248.793 ms) : 0, 248793
AppSec [baseline] (32.45 ms) : 0, 32450
AppSec [candidate] (32.387 ms) : 0, 32387
Debugger [baseline] (58.929 ms) : 0, 58929
Debugger [candidate] (59.124 ms) : 0, 59124
Remote Config [baseline] (593.449 µs) : 0, 593
Remote Config [candidate] (587.761 µs) : 0, 588
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.019 ms) : 0, 8019
Flare Poller [baseline] (5.001 ms) : 0, 5001
Flare Poller [candidate] (8.283 ms) : 0, 8283
section iast
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (808.181 ms) : 0, 808181
BytebuddyAgent [candidate] (818.608 ms) : 0, 818608
AgentMeter [baseline] (11.405 ms) : 0, 11405
AgentMeter [candidate] (11.599 ms) : 0, 11599
GlobalTracer [baseline] (238.942 ms) : 0, 238942
GlobalTracer [candidate] (241.649 ms) : 0, 241649
IAST [baseline] (30.915 ms) : 0, 30915
IAST [candidate] (28.567 ms) : 0, 28567
AppSec [baseline] (27.474 ms) : 0, 27474
AppSec [candidate] (29.753 ms) : 0, 29753
Debugger [baseline] (62.693 ms) : 0, 62693
Debugger [candidate] (64.499 ms) : 0, 64499
Remote Config [baseline] (528.049 µs) : 0, 528
Remote Config [candidate] (545.318 µs) : 0, 545
Telemetry [baseline] (7.778 ms) : 0, 7778
Telemetry [candidate] (7.848 ms) : 0, 7848
Flare Poller [baseline] (3.431 ms) : 0, 3431
Flare Poller [candidate] (3.482 ms) : 0, 3482

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	dd/fix/pekko-http-flaky-test-exception
git_commit_date	1776707964	1776715214
git_commit_sha	`6e28457`	`5a02e8b`
release_version	1.62.0-SNAPSHOT~6e28457d70	1.62.0-SNAPSHOT~5a02e8b8f4

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1776717668	1776717668
ci_job_id	1612783173	1612783173
ci_pipeline_id	108653713	108653713
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-jnccpa5e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-jnccpa5e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast:high_load	worse [+60.345µs; +162.582µs] or [+2.365%; +6.371%]	unsure [+0.755µs; +411.265µs] or [+0.010%; +5.495%]	unstable [-202.480op/s; +100.293op/s] or [-14.475%; +7.170%]	2.663ms	7.691ms	1347.750op/s	2.552ms	7.485ms	1398.844op/s
scenario:load:insecure-bank:profiling:high_load	better [-275.730µs; -116.211µs] or [-14.561%; -6.137%]	unstable [-1.607ms; -0.597ms] or [-27.269%; -10.123%]	unstable [+66.438op/s; +569.187op/s] or [+3.546%; +30.379%]	1.698ms	4.791ms	2191.406op/s	1.894ms	5.892ms	1873.594op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~5a02e8b8f4, baseline=1.62.0-SNAPSHOT~6e28457d70
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.452 ms) : 18261, 18643
.   : milestone, 18452,
appsec (18.675 ms) : 18485, 18866
.   : milestone, 18675,
code_origins (18.069 ms) : 17890, 18247
.   : milestone, 18069,
iast (18.094 ms) : 17915, 18274
.   : milestone, 18094,
profiling (18.141 ms) : 17962, 18320
.   : milestone, 18141,
tracing (17.966 ms) : 17787, 18145
.   : milestone, 17966,
section candidate
no_agent (19.257 ms) : 19062, 19452
.   : milestone, 19257,
appsec (18.884 ms) : 18690, 19079
.   : milestone, 18884,
code_origins (18.158 ms) : 17980, 18336
.   : milestone, 18158,
iast (17.882 ms) : 17704, 18059
.   : milestone, 17882,
profiling (17.925 ms) : 17747, 18104
.   : milestone, 17925,
tracing (17.968 ms) : 17790, 18146
.   : milestone, 17968,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.452 ms [18.261 ms, 18.643 ms]	-
appsec	18.675 ms [18.485 ms, 18.866 ms]	223.261 µs (1.2%)
code_origins	18.069 ms [17.89 ms, 18.247 ms]	-383.163 µs (-2.1%)
iast	18.094 ms [17.915 ms, 18.274 ms]	-357.535 µs (-1.9%)
profiling	18.141 ms [17.962 ms, 18.32 ms]	-310.885 µs (-1.7%)
tracing	17.966 ms [17.787 ms, 18.145 ms]	-485.813 µs (-2.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.257 ms [19.062 ms, 19.452 ms]	-
appsec	18.884 ms [18.69 ms, 19.079 ms]	-372.671 µs (-1.9%)
code_origins	18.158 ms [17.98 ms, 18.336 ms]	-1.099 ms (-5.7%)
iast	17.882 ms [17.704 ms, 18.059 ms]	-1.375 ms (-7.1%)
profiling	17.925 ms [17.747 ms, 18.104 ms]	-1.332 ms (-6.9%)
tracing	17.968 ms [17.79 ms, 18.146 ms]	-1.289 ms (-6.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~5a02e8b8f4, baseline=1.62.0-SNAPSHOT~6e28457d70
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.227 ms) : 1215, 1238
.   : milestone, 1227,
iast (3.271 ms) : 3226, 3316
.   : milestone, 3271,
iast_FULL (6.172 ms) : 6110, 6235
.   : milestone, 6172,
iast_GLOBAL (3.723 ms) : 3664, 3783
.   : milestone, 3723,
profiling (2.422 ms) : 2398, 2447
.   : milestone, 2422,
tracing (1.889 ms) : 1873, 1905
.   : milestone, 1889,
section candidate
no_agent (1.243 ms) : 1231, 1255
.   : milestone, 1243,
iast (3.398 ms) : 3349, 3448
.   : milestone, 3398,
iast_FULL (6.062 ms) : 6001, 6123
.   : milestone, 6062,
iast_GLOBAL (3.68 ms) : 3629, 3732
.   : milestone, 3680,
profiling (2.061 ms) : 2043, 2079
.   : milestone, 2061,
tracing (1.915 ms) : 1898, 1931
.   : milestone, 1915,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.227 ms [1.215 ms, 1.238 ms]	-
iast	3.271 ms [3.226 ms, 3.316 ms]	2.044 ms (166.6%)
iast_FULL	6.172 ms [6.11 ms, 6.235 ms]	4.945 ms (403.1%)
iast_GLOBAL	3.723 ms [3.664 ms, 3.783 ms]	2.497 ms (203.5%)
profiling	2.422 ms [2.398 ms, 2.447 ms]	1.196 ms (97.5%)
tracing	1.889 ms [1.873 ms, 1.905 ms]	662.648 µs (54.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.243 ms [1.231 ms, 1.255 ms]	-
iast	3.398 ms [3.349 ms, 3.448 ms]	2.155 ms (173.4%)
iast_FULL	6.062 ms [6.001 ms, 6.123 ms]	4.819 ms (387.7%)
iast_GLOBAL	3.68 ms [3.629 ms, 3.732 ms]	2.437 ms (196.1%)
profiling	2.061 ms [2.043 ms, 2.079 ms]	818.104 µs (65.8%)
tracing	1.915 ms [1.898 ms, 1.931 ms]	671.562 µs (54.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	dd/fix/pekko-http-flaky-test-exception
git_commit_date	1776707964	1776715214
git_commit_sha	`6e28457`	`5a02e8b`
release_version	1.62.0-SNAPSHOT~6e28457d70	1.62.0-SNAPSHOT~5a02e8b8f4

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1776717413	1776717413
ci_job_id	1612783178	1612783178
ci_pipeline_id	108653713	108653713
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-y7j25783 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-y7j25783 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~5a02e8b8f4, baseline=1.62.0-SNAPSHOT~6e28457d70
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.485 ms) : 1473, 1496
.   : milestone, 1485,
appsec (3.868 ms) : 3646, 4089
.   : milestone, 3868,
iast (2.287 ms) : 2217, 2357
.   : milestone, 2287,
iast_GLOBAL (2.318 ms) : 2249, 2388
.   : milestone, 2318,
profiling (2.114 ms) : 2059, 2169
.   : milestone, 2114,
tracing (2.085 ms) : 2032, 2139
.   : milestone, 2085,
section candidate
no_agent (1.489 ms) : 1477, 1500
.   : milestone, 1489,
appsec (3.857 ms) : 3631, 4083
.   : milestone, 3857,
iast (2.28 ms) : 2211, 2350
.   : milestone, 2280,
iast_GLOBAL (2.325 ms) : 2254, 2395
.   : milestone, 2325,
profiling (2.506 ms) : 2287, 2725
.   : milestone, 2506,
tracing (2.093 ms) : 2039, 2146
.   : milestone, 2093,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.485 ms [1.473 ms, 1.496 ms]	-
appsec	3.868 ms [3.646 ms, 4.089 ms]	2.383 ms (160.5%)
iast	2.287 ms [2.217 ms, 2.357 ms]	802.502 µs (54.1%)
iast_GLOBAL	2.318 ms [2.249 ms, 2.388 ms]	833.88 µs (56.2%)
profiling	2.114 ms [2.059 ms, 2.169 ms]	629.79 µs (42.4%)
tracing	2.085 ms [2.032 ms, 2.139 ms]	600.559 µs (40.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.489 ms [1.477 ms, 1.5 ms]	-
appsec	3.857 ms [3.631 ms, 4.083 ms]	2.368 ms (159.1%)
iast	2.28 ms [2.211 ms, 2.35 ms]	791.48 µs (53.2%)
iast_GLOBAL	2.325 ms [2.254 ms, 2.395 ms]	835.963 µs (56.2%)
profiling	2.506 ms [2.287 ms, 2.725 ms]	1.018 ms (68.4%)
tracing	2.093 ms [2.039 ms, 2.146 ms]	603.97 µs (40.6%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~5a02e8b8f4, baseline=1.62.0-SNAPSHOT~6e28457d70
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.051 s) : 15051000, 15051000
.   : milestone, 15051000,
appsec (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,
iast (18.39 s) : 18390000, 18390000
.   : milestone, 18390000,
iast_GLOBAL (17.827 s) : 17827000, 17827000
.   : milestone, 17827000,
profiling (14.947 s) : 14947000, 14947000
.   : milestone, 14947000,
tracing (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,
section candidate
no_agent (15.079 s) : 15079000, 15079000
.   : milestone, 15079000,
appsec (14.562 s) : 14562000, 14562000
.   : milestone, 14562000,
iast (18.509 s) : 18509000, 18509000
.   : milestone, 18509000,
iast_GLOBAL (18.1 s) : 18100000, 18100000
.   : milestone, 18100000,
profiling (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,
tracing (14.8 s) : 14800000, 14800000
.   : milestone, 14800000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.051 s [15.051 s, 15.051 s]	-
appsec	14.966 s [14.966 s, 14.966 s]	-85.0 ms (-0.6%)
iast	18.39 s [18.39 s, 18.39 s]	3.339 s (22.2%)
iast_GLOBAL	17.827 s [17.827 s, 17.827 s]	2.776 s (18.4%)
profiling	14.947 s [14.947 s, 14.947 s]	-104.0 ms (-0.7%)
tracing	14.907 s [14.907 s, 14.907 s]	-144.0 ms (-1.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.079 s [15.079 s, 15.079 s]	-
appsec	14.562 s [14.562 s, 14.562 s]	-517.0 ms (-3.4%)
iast	18.509 s [18.509 s, 18.509 s]	3.43 s (22.7%)
iast_GLOBAL	18.1 s [18.1 s, 18.1 s]	3.021 s (20.0%)
profiling	14.907 s [14.907 s, 14.907 s]	-172.0 ms (-1.1%)
tracing	14.8 s [14.8 s, 14.8 s]	-279.0 ms (-1.9%)

janhavis · 2026-04-20T16:12:05Z

❔ question: ‏Are there some other methods that need would response closing? That could be a good opportunity to fix it once for all because I don't think it's the first time we come up with this kind of fix.

Potentially. I will take a look.

@PerfectSlayer Pushed a change to close the response body in 3 more tests that don't consume the body stream, and won't implicitly close.

bm1549 · 2026-04-20T17:11:00Z

    }
  }

-  @Flaky(value = "https://github.com/DataDog/dd-trace-java/issues/9396", suites = ["PekkoHttpServerInstrumentationAsyncHttp2Test"])


You may want to consider keeping this for now

This PR hasn't deterministically proved that this flake is fixed so there may be other underlying issues here that may recur after this fix. If that does happen, this test may break a few PRs and we would need to re-introduce the annotation

That being said, if we can see that this fixed it empirically (i.e. this test does not flake for 30 days) we can remove this annotation afterwards with no worries

That sounds fair. Will add it back in.

…flow control issues Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

dd-octo-sts · 2026-04-20T21:02:33Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-04-20T21:02:37Z

View all feedbacks in Devflow UI.

2026-04-20 21:02:36 UTC ℹ️ Start processing command /merge

2026-04-20 21:02:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-04-20 23:03:13 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

janhavis · 2026-04-20T21:40:09Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-04-20T21:40:13Z

View all feedbacks in Devflow UI.

2026-04-20 21:40:13 UTC ℹ️ Start processing command /merge

2026-04-20 21:40:15 UTC ❌ MergeQueue

PR already in the queue with status in_progress

Fix flaky test exception by closing response in HttpServerTest

322715f

DD_C0320J Co-authored-by: janhavis <janhavi.sahasrabuddhe@gmail.com>

janhavis requested a review from a team as a code owner April 20, 2026 15:18

datadog-datadog-prod-us1-2 bot added the Bits AI label Apr 20, 2026

janhavis requested a review from ygree April 20, 2026 15:18

github-actions bot added tag: ai generated Largely based on code generated by an AI or LLM and removed Bits AI labels Apr 20, 2026

janhavis added the tag: flaky test Flaky tests label Apr 20, 2026

PerfectSlayer added comp: testing Testing type: bug Bug report and fix labels Apr 20, 2026

PerfectSlayer approved these changes Apr 20, 2026

View reviewed changes

PerfectSlayer reviewed Apr 20, 2026

View reviewed changes

bm1549 reviewed Apr 20, 2026

View reviewed changes

ygree approved these changes Apr 20, 2026

View reviewed changes

janhavis enabled auto-merge April 20, 2026 18:31

janhavis and others added 3 commits April 20, 2026 16:00

Close response body in redirect and blocking tests to prevent HTTP/2 …

fdd744d

…flow control issues Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Re-add @flaky annotation on test exception until fix is verified in CI

b36d2dd

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Merge branch 'master' into dd/fix/pekko-http-flaky-test-exception

5a02e8b

janhavis force-pushed the dd/fix/pekko-http-flaky-test-exception branch from 4385040 to 5a02e8b Compare April 20, 2026 20:00

janhavis added this pull request to the merge queue Apr 20, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 20, 2026

Conversation

janhavis commented Apr 20, 2026

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Apr 20, 2026

Uh oh!

datadog-official bot commented Apr 20, 2026

Uh oh!

github-actions bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

janhavis commented Apr 20, 2026

Uh oh!

pr-commenter bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

janhavis commented Apr 20, 2026

Uh oh!

bm1549 Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

janhavis Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

dd-octo-sts bot commented Apr 20, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

janhavis commented Apr 20, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Apr 20, 2026 •

edited

Loading

pr-commenter bot commented Apr 20, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Apr 20, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 bot commented Apr 20, 2026 •

edited

Loading