Skip to content

Fix flaky test exception in HttpServerTest #11164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janhavis wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −0
Open

Fix flaky test exception in HttpServerTest #11164

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
322715f
Fix flaky test exception by closing response in HttpServerTest
datadog-prod-us1-5[bot] Apr 20, 2026
fdd744d
Close response body in redirect and blocking tests to prevent HTTP/2 …
janhavis Apr 20, 2026
b36d2dd
Re-add @Flaky annotation on test exception until fix is verified in CI
janhavis Apr 20, 2026
5a02e8b
Merge branch 'master' into dd/fix/pekko-http-flaky-test-exception
janhavis Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...strumentation-testing/src/main/groovy/datadog/trace/agent/test/base/HttpServerTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,6 +1170,7 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {
}

response.body().contentLength() < 1 || redirectHasBody()
response.close()

and:
assertTraces(1) {
Expand Down Expand Up @@ -1210,6 +1211,8 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {
if (bubblesResponse()) {
assert response.body().string().contains(ERROR.body)
assert response.code() == ERROR.status
} else {
response.close()
}

and:
Expand Down Expand Up @@ -1255,6 +1258,8 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {
response.code() == EXCEPTION.status
if (testExceptionBody()) {
assert response.body().string() == EXCEPTION.body
} else {
response.close()
}

and:
Expand Down Expand Up @@ -1299,6 +1304,7 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {

expect:
response.code() == NOT_FOUND.status
response.close()

and:
assertTraces(1) {
Expand Down Expand Up @@ -1836,6 +1842,7 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {
response.code() == 301
response.header('location') == 'https://www.google.com/'
!handlerRan
response.close()

when:
TEST_WRITER.waitForTraces(1)
Expand Down Expand Up @@ -2117,6 +2124,7 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {
}
response.code() == 301
response.header("Location") == 'https://www.google.com/'
response.close()
TEST_WRITER.waitForTraces(1)
def trace = TEST_WRITER.get(0)

Expand Down
Loading