Skip to content

Remove @Flaky on debugger smoke tests - #13101

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
jpbempel/remote-flaky
Oct 30, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
jpbempel/remote-flaky

Conversation

@jpbempel

Copy link
Copy Markdown
Member

What Does This Do

since no flakiness for a week after several fixes, removing the annotation

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jpbempel jpbempel added tag: no release notes Changes to exclude from release notes type: refactoring comp: debugger Dynamic Instrumentation labels Oct 28, 2026
@jpbempel
jpbempel requested a review from a team as a code owner October 28, 2026 08:53
@jpbempel
jpbempel requested review from dudikeleti and removed request for a team October 28, 2026 08:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T08:54:36.883111Z d2c4ed7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The affected debugger smoke tests return to regular execution with their existing platform restrictions preserved. Continued runtime stability was not independently verified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit d2c4ed7

@dd-octo-sts

dd-octo-sts Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 13.93 s [-0.4%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 12.88 s 12.93 s [-1.2%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.18 s 17.01 s [+0.0%; +2.0%] (maybe worse)
startup:petclinic:iast:Agent 16.98 s 17.07 s [-1.4%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.80 s 16.88 s [-1.6%; +0.6%] (no difference)
startup:petclinic:sca:Agent 16.50 s 16.96 s [-7.1%; +1.6%] (no difference)
startup:petclinic:tracing:Agent 16.29 s 16.36 s [-1.3%; +0.5%] (no difference)

Commit: e1c769f7 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

since no flakiness for a week after several fixes, removing the
annotation
@jpbempel
jpbempel force-pushed the jpbempel/remote-flaky branch from d2c4ed7 to f94116d Compare October 29, 2026 18:15
@datadog-datadog-prod-us1-2

This comment has been minimized.

@jpbempel
jpbempel added this pull request to the merge queue Oct 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-30 14:06:59 UTC ℹ️ Start processing command /merge


2026-10-30 14:07:03 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-10-30 14:49:17 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 51487ce:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 30, 2026
@jpbempel
jpbempel force-pushed the jpbempel/remote-flaky branch from 9b69b7b to e1c769f Compare October 30, 2026 15:35
@jpbempel
jpbempel requested a review from a team as a code owner October 30, 2026 15:35
@jpbempel
jpbempel requested review from daniel-mohedano and removed request for a team October 30, 2026 15:35

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The timeout assertion matches the existing 200 ms evaluation limit, and JVM-specific exclusions remain intact. Removing the flaky-test markers introduces no identified defect, though ongoing test stability remains unverified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit e1c769f

@jpbempel
jpbempel enabled auto-merge October 30, 2026 16:09
@jpbempel
jpbempel added this pull request to the merge queue Oct 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-30 16:28:34 UTC ℹ️ Start processing command /merge


2026-10-30 16:28:39 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-10-30 17:21:24 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 30, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit d492b8a into master Oct 30, 2026
624 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the jpbempel/remote-flaky branch October 30, 2026 17:21
@github-actions github-actions Bot added this to the 1.69.0 milestone Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: debugger Dynamic Instrumentation tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants