Skip to content

Remove @Flaky on debugger smoke tests #13101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 3 commits into from
Oct 30, 2026
Merged

Remove @Flaky on debugger smoke tests #13101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f94116d
Remove @Flaky on debugger smoke tests
jpbempel Oct 28, 2026
38d3505
fix timeout
jpbempel Oct 30, 2026
e1c769f
still flaky
jpbempel Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...integration-tests/src/test/java/datadog/smoketest/InProductEnablementIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ void testDynamicInstrumentationResetEnablement() throws Exception {
waitForReTransformation(appUrl); // wait for retransformation of removed probe
}

@Flaky
@Test
@DisplayName("testDynamicInstrumentationEnablementWithLineProbe")
void testDynamicInstrumentationEnablementWithLineProbe() throws Exception {
Expand Down
4 changes: 1 addition & 3 deletions .../debugger-integration-tests/src/test/java/datadog/smoketest/LogProbesIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import datadog.trace.bootstrap.debugger.CapturedContext;
import datadog.trace.bootstrap.debugger.MethodLocation;
import datadog.trace.bootstrap.debugger.ProbeId;
import datadog.trace.test.util.Flaky;
import datadog.trace.test.util.NonRetryable;
import java.util.ArrayList;
import java.util.Arrays;
Expand All @@ -43,7 +42,6 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledIf;

@Flaky
@NonRetryable
public class LogProbesIntegrationTest extends SimpleAppDebuggerIntegrationTest {

Expand Down Expand Up @@ -643,7 +641,7 @@ void testTemplateTimeout() throws Exception {
snapshot -> {
if (snapshot.getProbe().getProbeId().equals(PROBE_ID)) {
assertEquals(1, snapshot.getEvaluationErrors().size());
assertEquals("timeout (50ms)", snapshot.getEvaluationErrors().get(0).getMessage());
assertEquals("timeout (200ms)", snapshot.getEvaluationErrors().get(0).getMessage());
snapshotReceived.set(true);
}
});
Expand Down
2 changes: 0 additions & 2 deletions ...bugger-integration-tests/src/test/java/datadog/smoketest/MetricProbesIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@
import com.datadog.debugger.el.DSL;
import com.datadog.debugger.el.ValueScript;
import com.datadog.debugger.probe.MetricProbe;
import datadog.trace.test.util.Flaky;
import datadog.trace.test.util.NonRetryable;
import java.io.IOException;
import java.util.concurrent.atomic.AtomicBoolean;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;

@Flaky
@NonRetryable
public class MetricProbesIntegrationTest extends SimpleAppDebuggerIntegrationTest {

Expand Down
2 changes: 0 additions & 2 deletions ...debugger-integration-tests/src/test/java/datadog/smoketest/ProbeStateIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import com.datadog.debugger.agent.ProbeStatus;
import com.datadog.debugger.probe.LogProbe;
import com.datadog.debugger.sink.Snapshot;
import datadog.trace.test.util.Flaky;
import datadog.trace.test.util.NonRetryable;
import java.util.Collections;
import java.util.concurrent.atomic.AtomicBoolean;
Expand Down Expand Up @@ -74,7 +73,6 @@ void testAddSourceFileProbeLargeInnerClasses() throws Exception {

@Test
@DisplayName("testAddSourceFileProbeHugeInnerClasses")
@Flaky
@DisabledIf(
value = "datadog.environment.JavaVirtualMachine#isJ9",
disabledReason = "Flaky on J9 JVMs")
Expand Down
2 changes: 0 additions & 2 deletions ...gger-integration-tests/src/test/java/datadog/smoketest/TracerDebuggerIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import com.datadog.debugger.sink.Snapshot;
import datadog.trace.bootstrap.debugger.MethodLocation;
import datadog.trace.bootstrap.debugger.ProbeId;
import datadog.trace.test.util.Flaky;
import datadog.trace.test.util.NonRetryable;
import datadog.trace.util.TagsHelper;
import java.util.concurrent.atomic.AtomicBoolean;
Expand All @@ -24,7 +23,6 @@
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;

@Flaky
@NonRetryable
public class TracerDebuggerIntegrationTest extends SpringBasedIntegrationTest {

Expand Down
Loading