feat(profiler): Support PHP DEBUG builds for the profiler#3908
Open
realFlowControl wants to merge 2 commits into
Open
feat(profiler): Support PHP DEBUG builds for the profiler#3908realFlowControl wants to merge 2 commits into
realFlowControl wants to merge 2 commits into
Conversation
|
Benchmarks [ profiler ]Benchmark execution time: 2026-05-26 10:47:21 Comparing candidate commit e7932ed in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics. |
The extern "C" alloc/free/realloc handlers delegate to a shared *_impl function to avoid duplicating the body across the cfg(php_debug) / cfg(not(php_debug)) variants. While LTO=fat + codegen-units=1 in release builds would inline these single-call-site wrappers anyway, this makes the perf contract explicit and removes any doubt about an extra call surviving in the allocator hot path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
realFlowControl
force-pushed
the
florian/profiler-debug
branch
from
12cd3e2 to
e7932ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds PHP
DEBUGbuild support to the profiler. It is not meant to be shipped as of know, we just need this in order to run ASAN tests for the Profiler in PHP ZTS builds, as the docker images we are using for our tests do only have a ZTS ASAN version that is also DEBUG.This PR's CI already shows, that adding this would have shown us the bug reported as #3896 in our own CI early.
Plan:
mastermasterso we have the fixmasterReviewer checklist