Repository navigation
Adopt E2E-first testing policy and prune redundant checks - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove eight redundant or implementation-only unit cases and adopt Factory's E2E-first testing policy. Keep configuration migration, secure storage permissions, encrypted fallback, invalid-data handling, output-content checks, command behavior and packed-install coverage.
The removed cases only check mkdir call avoidance, repeat encrypted fallback, echo mocked filesystem/property values from two wrappers, or count console calls without checking content. Production helpers remain unchanged, including exported helpers with possible external consumers. An independent preservation review read the removed cases, remaining suites and helper implementations. All 12 test files were inventoried and read; deletion decisions are limited to these evidenced cases, not a claim that every test owner/history was exhaustively audited.
Validation: 81 baseline cases passed. Final
npm run checkpassed typecheck, build, plugin checks, 73 tests and public-artifact validation.npm run test:packagepassed clean-consumer installation and executable/module/Playbook checks for both package names plus the existing local HTTP smoke. These local runs do not establish a CI timing improvement.No runtime behavior, public Command/API contract, dependency, package version, CI or release configuration changes. No publication or live service smoke was run. The production publishing gate was observed disabled and is unchanged. Shared policy: https://github.com/DealMachine/dealmachine-factory/pull/517.