fix(e2e): await network device row lookup#3146
Open
voidmatcha wants to merge 1 commit into
Open
Conversation
Signed-off-by: YONGJAE LEE <dev.yongjaelee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the network device row lookup helper to await each row text comparison before selecting a row.
Array.prototype.find()does not await async predicates, so the previous helper could treat the returned Promise as truthy and select the wrong row. The updated code uses a smallfor...ofloop sodeviceNameis compared against each row's text before returning the match.Why
This keeps the helper's existing behavior but makes the async lookup effective, which avoids false positives when E2E tests need to interact with a specific network device row.
Test plan
git diff --check origin/stable/2.x..HEAD/Users/yongjae/Documents/e2e-skills/skills/e2e-reviewer/scripts/scan.sh e2e/utils/controllers/vpn/createNetworkDevice.ts— no P0 findings; two existing P1/P2 heuristics remain outside this async lookup fix.pnpm --filter @defguard/e2e test ...targeted network-device flow — 2 passed locally.Found while reviewing the test suite with
e2e-skills/e2e-reviewer.