Skip to content

fix(e2e): await network device row lookup #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voidmatcha wants to merge 1 commit into
base: stable/2.x
Choose a base branch
from
Open

fix(e2e): await network device row lookup #3146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions e2e/utils/controllers/vpn/createNetworkDevice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ export const getDeviceRow = async ({
}) => {
const deviceList = page.locator('#devices-page-devices-list').first();
const deviceRows = await deviceList.locator('.device-row').all();
const row = deviceRows.find(async (val) => {
if ((await val.innerText()) === deviceName) {
return true;
} else {
return false;
let row: Locator | undefined;
for (const deviceRow of deviceRows) {
if ((await deviceRow.innerText()) === deviceName) {
row = deviceRow;
break;
}
});
}
expect(row).toBeDefined();
return row as Locator;
};
Expand Down