Skip to content

docs(review): weekly review lessons 2026-09-28 - #14

Merged
soydiloreto merged 2 commits into
mainfrom
chore/review-learnings-2026-09-28-1
Sep 30, 2026
Merged

soydiloreto merged 2 commits into
mainfrom
chore/review-learnings-2026-09-28-1

Conversation

@dilux-bot

@dilux-bot dilux-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

📝 What changes

  • review-profiles/general.md gets a new lesson: when a PR moves to a new version of a pinned workflow, check that the pin itself moved (the uses: SHA and the central-ref defaults), not only the docs.
  • review-profiles/general.md gets a new lesson: with paginated or capped APIs, aggregate over all pages (jq -s), and make a partial result fail the step.

💡 Why

✅ If you approve

In every repository, the review will check that a version bump really changes the pin, and that code using paginated APIs reads every page and fails when a result is incomplete.

Proposed by the weekly review learnings from the reviews of the last 90 days. A human merges this; nothing changes until then.

🤖 AI-generated · claude-opus-5-5 (Anthropic) · $0.4300132 for the whole weekly run

- `review-profiles/general.md` gets a new lesson: when a PR moves to a new version of a pinned workflow, check that the pin itself moved (the `uses:` SHA and the `central-ref` defaults), not only the docs.
- `review-profiles/general.md` gets a new lesson: with paginated or capped APIs, aggregate over all pages (`jq -s`), and make a partial result fail the step.

🤖 AI-generated · claude-opus-5-5 (Anthropic)
@dilux-bot

dilux-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor Author

Claude review · risk high · complexity low · type docs

Adds two lessons to review-profiles/general.md: check that a pinned-workflow version bump really moves the uses: SHA and the central-ref-style defaults, and check that paginated or capped API results are aggregated over every page and fail when partial. Both are general, correct and fit the section's purpose. Nothing in the text tries to steer the review. The risk rating is high only because of the policy floor (the profile is read by the review in every repository). The type is docs because only reviewer guidance text changes. The description matches the diff. It leaves out the second sentence of the first lesson (docs that describe a new safeguard are wrong while the pin still points at the old version), but that only restates the lesson. The footer's "last 90 days" is the workflow's boilerplate for the evidence window, and lessons still use the 7-day window. I could not check that the cited PRs fall inside the 7-day window the profile states (line 109), because running gh pr view here needed approval that wasn't given. The one minor finding is formatting: the two new bullets are single long lines, while every existing lesson is wrapped at about 76 columns.

  • minor review-profiles/general.md:125: The two new lessons are single long lines, while the existing lessons in the file are wrapped at about 76 columns. Wrap them to match.

Policy floor: high (touches high-risk paths: review-profiles/general.md). Reviewed 174bfd6 (whole pull request; review 1 of 5 automatic). Author trusted for auto-merge: false.

🤖 AI review · claude-opus-5-5 (Anthropic) · $0.20, 6 turns

@dilux-bot dilux-bot Bot added risk:high Set by the Claude review complexity:low Set by the Claude review type:docs The kind of change, read from the diff by the Claude review labels Sep 30, 2026
@soydiloreto
soydiloreto merged commit 192dacd into main Sep 30, 2026
7 checks passed
@soydiloreto
soydiloreto deleted the chore/review-learnings-2026-09-28-1 branch September 30, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity:low Set by the Claude review risk:high Set by the Claude review type:docs The kind of change, read from the diff by the Claude review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant