Skip to content

docs(review): weekly review lessons 2026-09-28 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soydiloreto merged 2 commits into from
Sep 30, 2026
Merged

docs(review): weekly review lessons 2026-09-28 #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55dc77d
docs(review): weekly review lessons 2026-09-28
dilux-bot[bot] Sep 28, 2026
174bfd6
Merge branch 'main' into chore/review-learnings-2026-09-28-1
soydiloreto Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions review-profiles/general.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,3 +122,5 @@ in the last 7 days; a human merges them.
claim is correct: say what would settle it, and expect the caller-visible
contract (trigger, inputs) in the workflow's header comment in the same
pull request.
- When a pull request says it moves to a new version of a pinned workflow, check that the pin itself moved (the `uses:` SHA and every `central-ref`-style default), not only the comments and docs. Docs that describe a safeguard of the new version are wrong while the pin still points at the old one.
- With a paginated or capped API (`gh api --paginate`, a files list), check that aggregates run over all pages (`jq -s`, not per page) and that a partial result fails the step instead of passing as complete.
Loading