Fix docs deploy: disable AOT on Playground.Wasm#32
Merged
Conversation
.NET 10's wasm-tools workload rejects RunAOTCompilation when PublishTrimmed is false, which broke the Publish step in docs.yml: error : AOT is not supported without IL trimming (PublishTrimmed=true required). We can't enable trimming because Roslyn + EF Core don't trim cleanly, so disable AOT instead — the playground runs interpreted, trading Roslyn startup speed for a working build. Also drops the wasm-tools workload install from all 4 workflows; without AOT nothing in the publish path invokes emscripten / wasm-opt. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
worth it for now |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the docs deployment pipeline by disabling WebAssembly AOT compilation for the Blazor playground project (since .NET 10’s wasm-tools now requires trimming for AOT, and trimming can’t be enabled for this app). It also removes unnecessary wasm-tools workload installation steps from GitHub Actions workflows to speed up CI.
Changes:
- Disable WASM AOT for
Playground.Wasmby removingRunAOTCompilationand documenting why trimming/AOT are off. - Remove
dotnet workload install wasm-toolsfrom CI, docs deploy, release, and benchmarks workflows.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Docs/Playground.Wasm/ExpressiveSharp.Docs.Playground.Wasm.csproj | Removes AOT and updates trimming/AOT rationale to keep publishing working under .NET 10. |
| .github/workflows/release.yml | Drops wasm-tools workload install step (no longer needed without AOT). |
| .github/workflows/docs.yml | Drops wasm-tools workload install step before publishing the playground. |
| .github/workflows/ci.yml | Drops wasm-tools workload install step from the main CI job. |
| .github/workflows/benchmarks.yml | Drops wasm-tools workload install step from benchmark runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error : AOT is not supported without IL trimming (PublishTrimmed=true required).Test plan
🤖 Generated with Claude Code