Fix settings panel crash: AdwEntryRow has no subtitle property (1.0.3) - #8
Merged
Merged
Conversation
Reported by Core447 (StreamController maintainer) while reviewing the
Store submission PR: opening the action's settings threw
TypeError: gobject 'AdwEntryRow' doesn't support property 'subtitle'
AdwEntryRow only inherits AdwPreferencesRow's 'title' - unlike
AdwActionRow/AdwComboRow, it has no 'subtitle' property, so passing
one as a GObject construct kwarg crashes immediately. The log-path and
sessions-directory rows did this; the third EntryRow (refresh
interval) never passed subtitle and was unaffected. Moved the hint
text to set_tooltip_text() on each row instead of dropping it.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UJ3K16EeaK24LWUksYKcBd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash reported by @Core447 (StreamController maintainer) while reviewing the Store submission: opening the action's settings panel threw
Root cause
AdwEntryRowonly inheritsAdwPreferencesRow'stitle— unlikeAdwActionRow/AdwComboRow(which do havesubtitle), it has nosubtitleproperty at all. Passing one as a GObject construct keyword argument (Adw.EntryRow(title=..., subtitle=...)) crashes immediately. Two of the threeAdw.EntryRowinstances inget_config_rows()did this (log path, sessions directory); the third (refresh interval) never passedsubtitleand was fine, as was theAdw.ComboRowfor the bottom-label picker.Fix
Moved the hint text to
set_tooltip_text()on each affected row instead of dropping it. Version bumped to 1.0.3.Testing
python3 -m py_compile+ JSON validation on all changed files. Can't spin up a real GTK/Adw + StreamController environment here to reproduce the crash directly, but the fix is mechanical: it's exactly the unsupported constructor argument named in the traceback, removed from the exact two call sites that had it.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01UJ3K16EeaK24LWUksYKcBd
🤖 Generated with Claude Code
Generated by Claude Code