Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 1.0.3

- Fixed the settings panel crashing on open (`TypeError: gobject 'AdwEntryRow' doesn't support property 'subtitle'`), reported by [@Core447](https://github.com/Core447) while reviewing the StreamController Store submission. `AdwEntryRow` has no `subtitle` property (unlike `AdwActionRow`/`AdwComboRow`, which do) — passing one as a construct argument crashed as soon as the log-path or sessions-directory rows were built. Moved that hint text to a tooltip on each row instead.

## 1.0.2

Real-world fixes from [@parkour86](https://github.com/parkour86) testing against actual Grok Build/SuperGrok installs ([#3](https://github.com/ENjxzlt/Grok-Usage-Streamcontroller/issues/3), [#4](https://github.com/ENjxzlt/Grok-Usage-Streamcontroller/pull/4), [#5](https://github.com/ENjxzlt/Grok-Usage-Streamcontroller/pull/5), [#6](https://github.com/ENjxzlt/Grok-Usage-Streamcontroller/pull/6)):
Expand Down
2 changes: 1 addition & 1 deletion about.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "ENjxzlt",
"release-notes": {
"path": "CHANGELOG.md",
"version": "1.0.2"
"version": "1.0.3"
},
"credits": {},
"comments": {},
Expand Down
15 changes: 9 additions & 6 deletions actions/GrokUsage/GrokUsage.py
Original file line number Diff line number Diff line change
Expand Up @@ -332,15 +332,18 @@ def _settings(self) -> dict:
def get_config_rows(self) -> list:
settings = self._settings()

log_path_row = Adw.EntryRow(
title=self.tr("grok-usage.log-path.title"), subtitle=self.tr("grok-usage.log-path.subtitle")
)
# AdwEntryRow (unlike AdwActionRow/AdwComboRow below) has no "subtitle"
# property - passing one as a construct kwarg crashes with
# "TypeError: gobject 'AdwEntryRow' doesn't support property
# 'subtitle'" as soon as the settings panel is opened. Set it as a
# tooltip instead so the hint isn't lost entirely.
log_path_row = Adw.EntryRow(title=self.tr("grok-usage.log-path.title"))
log_path_row.set_tooltip_text(self.tr("grok-usage.log-path.subtitle"))
log_path_row.set_text(str(settings.get("log_path", DEFAULT_LOG_PATH)))
log_path_row.connect("notify::text", self._on_log_path_changed)

sessions_dir_row = Adw.EntryRow(
title=self.tr("grok-usage.sessions-dir.title"), subtitle=self.tr("grok-usage.sessions-dir.subtitle")
)
sessions_dir_row = Adw.EntryRow(title=self.tr("grok-usage.sessions-dir.title"))
sessions_dir_row.set_tooltip_text(self.tr("grok-usage.sessions-dir.subtitle"))
sessions_dir_row.set_text(str(settings.get("sessions_dir", DEFAULT_SESSIONS_DIR)))
sessions_dir_row.connect("notify::text", self._on_sessions_dir_changed)

Expand Down
2 changes: 1 addition & 1 deletion main.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@ def __init__(self):
self.register(
plugin_name=self.lm.get("plugin.name"),
github_repo="https://github.com/ENjxzlt/Grok-Usage-Streamcontroller",
plugin_version="1.0.2",
plugin_version="1.0.3",
app_version="1.5.0-beta",
)
2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.0.2",
"version": "1.0.3",
"thumbnail": "store/Thumbnail.png",
"id": "dev_enjxz_GrokUsage",
"name": "Grok Usage",
Expand Down