Isolate SqlMessageStorage tests with per-test table prefixes#6440
Open
sbking wants to merge 1 commit into
Open
Isolate SqlMessageStorage tests with per-test table prefixes#6440sbking wants to merge 1 commit into
sbking wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
SqlMessageStoragetests run concurrently, but each dialect currently shares one set of tables and five tests truncate them. Under load, one test can consume another test's messages or delete its rows.SqlMessageStorage.layerWith({ prefix })truncatehelperI considered serializing the file, but per-test prefixes preserve its concurrent scheduling and remove the shared state instead of relying on test order.
Testing
pnpm vitest run packages/platform-node/test/cluster/SqlMessageStorage.test.tspnpm checkpnpm lint