Skip to content

Isolate SqlMessageStorage tests with per-test table prefixes #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbking wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −29
Open

Isolate SqlMessageStorage tests with per-test table prefixes #6440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 16 additions & 29 deletions packages/platform-node/test/cluster/SqlMessageStorage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,24 +16,21 @@ import {
StreamRpc
} from "./MessageStorageTest.ts"

const StorageLive = SqlMessageStorage.layer.pipe(
Layer.provideMerge(Snowflake.layerGenerator),
Layer.provide(ShardingConfig.layerDefaults)
)

const truncate = Effect.gen(function*() {
const sql = yield* SqlClient.SqlClient
yield* sql`DELETE FROM cluster_replies`
yield* sql`DELETE FROM cluster_messages`
})
// Each test provides its own storage layer with a distinct table prefix, so
// concurrently running tests never share tables.
const storageLive = (prefix: string) =>
SqlMessageStorage.layerWith({ prefix }).pipe(
Layer.provideMerge(Snowflake.layerGenerator),
Layer.provide(ShardingConfig.layerDefaults)
)

describe("SqlMessageStorage", () => {
;([
["pg", Layer.orDie(PgContainer.layerClient)],
["mysql", Layer.orDie(MysqlContainer.layerClient)],
["sqlite", Layer.orDie(SqliteLayer)]
] as const).forEach(([label, layer]) => {
it.layer(StorageLive.pipe(Layer.provideMerge(layer)), {
it.layer(layer, {
timeout: 120000
})(label, (it) => {
it.effect("saveRequest", () =>
Expand All @@ -59,7 +56,7 @@ describe("SqlMessageStorage", () => {
messages = yield* storage.unprocessedMessages([request.envelope.address.shardId])
expect(messages).toHaveLength(5)
expect(messages.map((m: any) => m.envelope.payload.id)).toEqual([6, 7, 8, 9, 10])
}))
}).pipe(Effect.provide(storageLive("save_request"))))

it.effect("saveReply + saveRequest duplicate", () =>
Effect.gen(function*() {
Expand Down Expand Up @@ -113,12 +110,10 @@ describe("SqlMessageStorage", () => {
}
const error = yield* Effect.flip(Fiber.join(fiber))
expect(error._tag).toEqual("PersistenceError")
}))
}).pipe(Effect.provide(storageLive("stream_replies"))))

it.effect("detects duplicates", () =>
Effect.gen(function*() {
yield* truncate

const storage = yield* MessageStorage.MessageStorage
yield* storage.saveRequest(
yield* makeRequest({
Expand All @@ -133,12 +128,10 @@ describe("SqlMessageStorage", () => {
})
)
expect(result._tag).toEqual("Duplicate")
}))
}).pipe(Effect.provide(storageLive("detects_duplicates"))))

it.effect("unprocessedMessages", () =>
Effect.gen(function*() {
yield* truncate

const storage = yield* MessageStorage.MessageStorage
const request = yield* makeRequest()
yield* storage.saveRequest(request)
Expand All @@ -149,24 +142,20 @@ describe("SqlMessageStorage", () => {
yield* storage.saveRequest(yield* makeRequest())
messages = yield* storage.unprocessedMessages([request.envelope.address.shardId])
expect(messages).toHaveLength(1)
}))
}).pipe(Effect.provide(storageLive("unprocessed_messages"))))

it.effect("unprocessedMessages excludes complete requests", () =>
Effect.gen(function*() {
yield* truncate

const storage = yield* MessageStorage.MessageStorage
const request = yield* makeRequest()
yield* storage.saveRequest(request)
yield* storage.saveReply(yield* makeReply(request))
const messages = yield* storage.unprocessedMessages([request.envelope.address.shardId])
expect(messages).toHaveLength(0)
}))
}).pipe(Effect.provide(storageLive("unprocessed_complete"))))

it.effect("repliesFor", () =>
Effect.gen(function*() {
yield* truncate

const storage = yield* MessageStorage.MessageStorage
const request = yield* makeRequest()
yield* storage.saveRequest(request)
Expand All @@ -176,7 +165,7 @@ describe("SqlMessageStorage", () => {
replies = yield* storage.repliesFor([request])
expect(replies).toHaveLength(1)
expect(replies[0].requestId).toEqual(request.envelope.requestId)
}))
}).pipe(Effect.provide(storageLive("replies_for"))))

it.effect("registerReplyHandler", () =>
Effect.gen(function*() {
Expand All @@ -194,12 +183,10 @@ describe("SqlMessageStorage", () => {
yield* storage.saveReply(yield* makeReply(request))
yield* latch.await
yield* Fiber.await(fiber)
}))
}).pipe(Effect.provide(storageLive("register_reply_handler"))))

it.effect("unprocessedMessagesById", () =>
Effect.gen(function*() {
yield* truncate

const storage = yield* MessageStorage.MessageStorage
const request = yield* makeRequest()
yield* storage.saveRequest(request)
Expand All @@ -208,7 +195,7 @@ describe("SqlMessageStorage", () => {
yield* storage.saveReply(yield* makeReply(request))
messages = yield* storage.unprocessedMessagesById([request.envelope.requestId])
expect(messages).toHaveLength(0)
}))
}).pipe(Effect.provide(storageLive("unprocessed_by_id"))))
})
})
})
Expand Down