Skip to content

🎨 Palette: Replace OS-specific pause with cross-platform explicit prompt#131

Closed
EiJackGH wants to merge 2 commits into
mainfrom
palette-cpp-exit-prompt-236524697831414373
Closed

🎨 Palette: Replace OS-specific pause with cross-platform explicit prompt#131
EiJackGH wants to merge 2 commits into
mainfrom
palette-cpp-exit-prompt-236524697831414373

Conversation

@EiJackGH

Copy link
Copy Markdown
Owner

💡 What: Replaced system("pause") with cin.get() in the C++ number guessing game, adding an explicit "Press Enter to exit..." message. Recorded the learning in the palette journal.

🎯 Why: system("pause") is a Windows-only shell command that breaks on macOS and Linux, or causes messy outputs. Also, "Press any key to continue" is less clear than explicitly stating "Press Enter to exit".

📸 Before/After:
Before (Windows only): Press any key to continue . . .
After (Cross-platform): Press Enter to exit...

Accessibility: Provides a clear text instruction for what the user needs to do to close the program, avoiding confusing OS-specific default prompts.


PR created automatically by Jules for task 236524697831414373 started by @EiJackGH

Replaced the Windows-specific `system("pause")` call in `NumberGuess/NumberGuess.cpp` with standard C++ `cin.get()` along with an explicit "Press Enter to exit..." instruction. This improves cross-platform consistency and accessibility. Recorded UX learning in `.Jules/palette.md`.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…mpt and fix CI

Replaced the Windows-specific `system("pause")` call in `NumberGuess/NumberGuess.cpp` with standard C++ `cin.get()` along with an explicit "Press Enter to exit..." instruction. This improves cross-platform consistency and accessibility. Recorded UX learning in `.Jules/palette.md`.
Also removed `venv` from `requirements.txt` to fix CI failures, as `venv` is a standard module that should not be pip-installed.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant