[NoQA] Remove the DualEntry beta - #100621
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
grgia
left a comment
There was a problem hiding this comment.
nothing code blocking, needs description
|
Putting this on HOLD to handle a last-minute bug found by QA. |
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.82-0 🚀
|
|
🤖 Yes — one help site change is required. Draft PR: Docs updates for E/A#100621 remove DualEntry from upcoming integrations reference ( Removing the No other article needed a change. The two DualEntry articles never mentioned a beta and already document the shipped flow, and their "Control plan" eligibility line is still correct — connecting remains gated on What I checkedEvery help site file mentioning DualEntry
The Connections list is generated from the connections directory, so DualEntry needed no manual listing anywhere. Both referenced screenshots ( UI label verification (dev NewDot, web) Confirmed against the live app, so the affected articles' labels match exactly: navigation tab Workspaces, workspace settings row Accounting, section heading Connections, integration name DualEntry, action button Connect. DualEntry now renders in the Connections list alongside QuickBooks Online, Intuit Enterprise Suite, QuickBooks Desktop, Xero, NetSuite, Sage Intacct, Certinia, and Rillet — while Campfire and Business Central stay hidden, matching the betas this PR left in place. Authoring compliance The change touches only frontmatter, so headings, structure, and cross-links in the DualEntry articles are unchanged and still satisfy @lakchote, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.86-0 🚀
|
Explanation of Change
Remove the DualEntry beta gate from workspace Accounting so eligible workspaces can connect without beta enrollment as part of the DualEntry rollout.
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari