Skip to content

[NoQA] Remove the DualEntry beta - #100621

Merged
Beamanator merged 5 commits into
mainfrom
lucien/remove-dualentry-beta
Sep 17, 2026
Merged

Beamanator merged 5 commits into
mainfrom
lucien/remove-dualentry-beta

Conversation

@lakchote

@lakchote lakchote commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Remove the DualEntry beta gate from workspace Accounting so eligible workspaces can connect without beta enrollment as part of the DualEntry rollout.

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 91.52% <ø> (ø)
...ages/workspace/accounting/PolicyAccountingPage.tsx 0.00% <ø> (ø)
... and 14 files with indirect coverage changes

@lakchote
lakchote marked this pull request as ready for review September 16, 2026 15:39
@lakchote
lakchote requested review from a team as code owners September 16, 2026 15:39
@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team September 16, 2026 15:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-09-16T16:10:04.723954Z 5480252 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from grgia and removed request for a team September 16, 2026 15:40
@melvin-bot

melvin-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia
grgia previously approved these changes Sep 16, 2026

@grgia grgia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing code blocking, needs description

@lakchote lakchote changed the title Remove the DualEntry beta [HOLD] Remove the DualEntry beta Sep 16, 2026
@lakchote

Copy link
Copy Markdown
Contributor Author

Putting this on HOLD to handle a last-minute bug found by QA.

trjExpensify
trjExpensify previously approved these changes Sep 16, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yah! 👍

@lakchote lakchote changed the title [HOLD] Remove the DualEntry beta Remove the DualEntry beta Sep 17, 2026
@lakchote lakchote changed the title Remove the DualEntry beta [NoQA] Remove the DualEntry beta Sep 17, 2026
@lakchote
lakchote dismissed stale reviews from trjExpensify and grgia via 8957c9d September 17, 2026 17:29

@Beamanator Beamanator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Beamanator
Beamanator merged commit 3908430 into main Sep 17, 2026
42 of 46 checks passed
@Beamanator
Beamanator deleted the lucien/remove-dualentry-beta branch September 17, 2026 17:45
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.82-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Yes — one help site change is required. Draft PR: Docs updates for E/A#100621 remove DualEntry from upcoming integrations reference (Expensify/App#101483)

Removing the DUALENTRY beta gate makes DualEntry show in the Connections list on the workspace Accounting page for every workspace, so the internal upcoming-features reference was stale: docs/articles/Unlisted/Upcoming-Integrations-And-Accounting.md:3-4 still listed DualEntry as planned/in-development in its description and keywords. AgentZero would have answered "DualEntry is coming soon" for a live, connectable integration. DualEntry was already absent from that page's bullet list, so the fix is limited to those two frontmatter lines.

No other article needed a change. The two DualEntry articles never mentioned a beta and already document the shipped flow, and their "Control plan" eligibility line is still correct — connecting remains gated on isControlPolicy at src/pages/workspace/accounting/PolicyAccountingPage.tsx:288, which this PR did not touch.

What I checked

Every help site file mentioning DualEntry

File Verdict
docs/articles/Unlisted/Upcoming-Integrations-And-Accounting.md Updated — DualEntry removed from description and keywords
docs/articles/new-expensify/connections/dualentry/Connect-to-DualEntry.md No change — no beta wording; eligibility and steps still accurate
docs/articles/new-expensify/connections/dualentry/Configure-DualEntry.md No change — import/export/advanced settings unaffected
docs/articles/new-expensify/connections/dualentry/_meta.yml No change — nav title is already DualEntry

The Connections list is generated from the connections directory, so DualEntry needed no manual listing anywhere. Both referenced screenshots (DualEntry_connect.png, DualEntry_configure.png) exist in docs/assets/images/.

UI label verification (dev NewDot, web)

Confirmed against the live app, so the affected articles' labels match exactly: navigation tab Workspaces, workspace settings row Accounting, section heading Connections, integration name DualEntry, action button Connect. DualEntry now renders in the Connections list alongside QuickBooks Online, Intuit Enterprise Suite, QuickBooks Desktop, Xero, NetSuite, Sage Intacct, Certinia, and Rillet — while Campfire and Business Central stay hidden, matching the betas this PR left in place.

Authoring compliance

The change touches only frontmatter, so headings, structure, and cross-links in the DualEntry articles are unchanged and still satisfy HELP_AUTHORING_GUIDELINES.md, HELPSITE_NAMING_CONVENTIONS.md, and TEMPLATE.md. I could not run cspell in this environment; the edit only deletes an existing word, so it cannot introduce a new spelling failure.

@lakchote, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.86-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants