Conversation
…hat the beta gate is gone Co-authored-by: Lucien Akchoté <lakchote@users.noreply.github.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a minimal, targeted metadata edit to docs/articles/Unlisted/Upcoming-Integrations-And-Accounting.md, removing "DualEntry" from the description and keywords YAML frontmatter fields. This correctly reflects that DualEntry has reached general availability and no longer belongs in an internal "upcoming integrations" reference. The change is accurate, in scope, and keeps the metadata truthful. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This change is a two-line metadata edit; no inline comments were necessary. |
Explanation of Change
Help site follow-up to [NoQA] Remove the DualEntry beta (
Expensify/App#100621), which deleted theDUALENTRYbeta and its gate inPolicyAccountingPage, so DualEntry now appears in the Connections list on the workspace Accounting page for every workspace instead of only beta-enrolled ones.The internal AgentZero reference page for upcoming integrations still listed DualEntry as planned/in-development in its
descriptionandkeywords, even though DualEntry was already dropped from that page's bullet list. Left as-is, AgentZero would answer "DualEntry is coming soon" for an integration that is now live and connectable, so this removes the two stale DualEntry references.No other help site article needed a change:
docs/articles/new-expensify/connections/dualentry/Connect-to-DualEntry.mdandConfigure-DualEntry.mdalready document the live flow and never mentioned a beta, so they are accurate as written.isControlPolicyinPolicyAccountingPage, which this PR did not touch.UI labels used in the affected articles were verified against dev NewDot on web: the navigation tab is Workspaces, the workspace settings row is Accounting, the section heading is Connections, the integration name is DualEntry, and its action button is Connect.
Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
Not applicable — this PR only changes help site markdown frontmatter.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@lakchote, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.