Fix time display format by using localized format - #101017
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01338eeb71
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@roryabraham Switching from en-GB to en-US for timezone data for en locale has some tz rendering changes.
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
dylanexpensify
left a comment
dylanexpensify
left a comment
There was a problem hiding this comment.
Looks good from a product perspective 👍
These changes LGTM 👍🏼 |
|
@linhvovan29546 looks like you were tagged above but unassigned due to some race condition. Please do C+ review here |
roryabraham
left a comment
roryabraham
left a comment
There was a problem hiding this comment.
Mostly LGTM, one question 👍🏼
| return ''; | ||
| } | ||
| return formatTimeWithPeriod(translate, new Date(dateTimeString), CONST.DATE.TIME_FORMAT_WITHOUT_PERIOD); | ||
| // Pinned to English, not the active language. This value is the TimePicker's wire format: it is parsed back by |
There was a problem hiding this comment.
I'm a bit confused by this comment still - why not update both sides to locale-specific date format? Is it not display to the user?
There was a problem hiding this comment.
@roryabraham This is mainly used to handle values which will be passed to BE, so we keep everything in English here.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-16.at.18.21.05.movAndroid: mWeb ChromeScreen.Recording.2026-09-16.at.18.23.13.moviOS: HybridAppScreen.Recording.2026-09-16.at.18.24.57.moviOS: mWeb SafariScreen.Recording.2026-09-16.at.18.18.01.movMacOS: Chrome / SafariBefore After 
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87c97796c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3d30cab
|
@shubham1206agra Spell check failed |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.82-0 🚀
|
Help site changes are requiredThis PR changes user-visible behavior for a setting the help site already documents, so one article needed updating. Draft PR: Docs updates for E/A#101017 time format follows Language setting Why a docs change is neededSwitching Account Settings documents the Language setting but never mentioned it affects the time format. A member switching to Español now sees I confirmed the behavior in the running app on web rather than inferring it from the diff:
What the docs PR changesOnly
The clock convention per language comes from the table in your PR description. All UI labels and the language option names were checked against the live UI for exact capitalization. The article follows Articles I checked and ruled out
Checks run: @shubham1206agra, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.86-0 🚀
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.89-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |
7 participants
Explanation of Change
Fixed Issues
$ #98088
Tests
PS - The time format is as follows:
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-09-11.at.10.27.06.PM.mov