Skip to content

Docs updates for E/A#101017 time format follows Language setting - #101482

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsTimeFormatLocalized
Draft

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsTimeFormatLocalized

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Fix time display format by using localized format changed CONST.DATE.LOCAL_TIME_FORMAT from the hardcoded 12-hour pattern h:mm a to date-fns' localized p token, so every displayed time now follows the clock convention of the member's selected Language instead of always using a US 12-hour clock. It also switched the English date-fns locale from en-GB to en-US.

That is a user-visible behavior change to a setting the help site already documents, but no article said the Language setting affects the time format. A member who switches to Español now sees 22:25 where they previously saw 10:25 PM, with nothing in the help site explaining why.

This PR updates docs/articles/new-expensify/settings/Account-Settings.md:

  • Adds a ## What time format each language uses section with a per-language table of the 12-hour vs 24-hour clock and an example time for each of the 11 supported languages, plus a list of the places in the product where times are shown.
  • Adds two FAQ entries: whether the time format can be changed independently of the language, and why times appear on a 24-hour clock after switching language.
  • Adds time format, 12-hour clock, and 24-hour clock to the article keywords for retrieval.

The clock convention per language is taken from the table in the linked PR's description. The UI labels used (Account, Preferences, Language, and the language option names) were verified against the running app rather than written from memory.

Docs-only change — no product code is touched.

Fixed Issues

$ #98088
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Docs-only change, so there is nothing to screenshot in the product. The UI labels referenced in the article were verified in the running app on web:

Verified Result
Settings row and page title used to change language Row label is Language under Account > Preferences; picker page title is Language
Language option labels English, Deutsch, Español, Français, Italiano, Nederlands, Polski, Português (BR), Ελληνικά, 中文 (简体), 日本語
Chat timestamp with English selected Today at 10:25 PM — 12-hour clock
Chat timestamp after switching to Español Hoy a las 22:25 — 24-hour clock
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@shubham1206agra, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 17, 2026 22:35
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants