Conversation
Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>
52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fix time display format by using localized format changed
CONST.DATE.LOCAL_TIME_FORMATfrom the hardcoded 12-hour patternh:mm ato date-fns' localizedptoken, so every displayed time now follows the clock convention of the member's selected Language instead of always using a US 12-hour clock. It also switched the English date-fns locale fromen-GBtoen-US.That is a user-visible behavior change to a setting the help site already documents, but no article said the Language setting affects the time format. A member who switches to Español now sees
22:25where they previously saw10:25 PM, with nothing in the help site explaining why.This PR updates
docs/articles/new-expensify/settings/Account-Settings.md:## What time format each language usessection with a per-language table of the 12-hour vs 24-hour clock and an example time for each of the 11 supported languages, plus a list of the places in the product where times are shown.time format,12-hour clock, and24-hour clockto the articlekeywordsfor retrieval.The clock convention per language is taken from the table in the linked PR's description. The UI labels used (Account, Preferences, Language, and the language option names) were verified against the running app rather than written from memory.
Docs-only change — no product code is touched.
Fixed Issues
$ #98088
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Docs-only change, so there is nothing to screenshot in the product. The UI labels referenced in the article were verified in the running app on web:
Languageunder Account > Preferences; picker page title isLanguageEnglish,Deutsch,Español,Français,Italiano,Nederlands,Polski,Português (BR),Ελληνικά,中文 (简体),日本語Today at 10:25 PM— 12-hour clockHoy a las 22:25— 24-hour clockAndroid: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@shubham1206agra, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.