Skip to content

Add Vendor filter to expense Search - #101309

Draft
c3024 wants to merge 11 commits into
Expensify:mainfrom
c3024:chaitanya/681919-vendor-search-filter-column
Draft

c3024 wants to merge 11 commits into
Expensify:mainfrom
c3024:chaitanya/681919-vendor-search-filter-column

Conversation

@c3024

@c3024 c3024 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds Vendor to expense Search as an advanced filter, the filter half of the Release 5 item of the vendor matching design doc. The Vendor column ships separately in #101410, which this branch builds on, so this PR's diff includes the column commit until that PR merges.

  • The filter offers a multi-select of vendor names from the workspaces the user administers, loaded through the new OpenSearchVendorFiltersPage command into policyVendors_, plus a "No vendor" value. Auth matches the stored vendor name the same way it matches category, so identical names across workspaces match together.
  • The filter is gated on hasVendorFeature(policy, isBetaEnabled(vendorMatching)) across the user's workspaces, the same gate as the expense Vendor field. Since connection config only reaches admins, non-admin members never see it.
  • The label reads "Supplier" only when every eligible workspace takes its vendors from Xero, otherwise "Vendor".

The noVendor and noSupplier strings were added to every locale because the locale files are typed against en.ts and this PR comes from a fork, so the translation workflow does not run on it. They can be regenerated after merge.

Backend: https://github.com/Expensify/Auth/pull/24565 and https://github.com/Expensify/Web-Expensify/pull/56224 must deploy first, otherwise the filter returns 402 Filter translator not found for: vendor and the picker stays empty.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/681919

Tests

  1. Sign in as an admin of a workspace connected to QBO with "Export company card expenses as" set to Credit card, with at least one non-reimbursable expense that has a vendor assigned and one without.
  2. Open Reports, Expenses, and click Filters. Verify Vendor appears next to Category and Tag.
  3. Open Vendor and verify the workspace's synced vendors and "No vendor" are listed.
  4. Select one vendor and apply. Verify only expenses with that vendor are returned and the filter chip reads "Vendor: ".
  5. Select "No vendor" and verify only expenses without a vendor are returned.
  6. Type vendor:<name> in the search input and verify the same results as step 4.
  7. Save the search and verify the saved search re-applies the vendor filter when opened.
  8. Sign in as a non-admin member of the same workspace and verify Vendor is absent from the filter list.
  9. Sign in as an admin whose only eligible workspace is connected to Xero (with the vendorMatching beta) and verify the filter and its chips read "Supplier" and the empty option reads "No supplier".
  10. Run npm test -- tests/unit/PolicyUtilsTest.ts tests/unit/hooks/useAdvancedSearchFilters.test.ts tests/unit/Search/SearchQueryUtilsTest.ts tests/unit/Search/SearchUIUtilsTest.ts and verify all suites pass.
Screenshot 2026-09-17 at 5 56 16 PM Screenshot 2026-09-17 at 5 56 05 PM Screenshot 2026-09-17 at 5 55 14 PM Screenshot 2026-09-17 at 5 55 01 PM
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline and open Filters, Vendor.
  2. Verify the picker shows the vendors already loaded and no loading spinner hangs.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot

melvin-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@c3024 c3024 changed the title Add Vendor column and filter to expense Search Add Vendor filter to expense Search Sep 17, 2026
@melvin-bot

melvin-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually.

@melvin-bot

melvin-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually.

@c3024 c3024 changed the title Add Vendor filter to expense Search [Internal QA] Add Vendor filter to expense Search Sep 17, 2026
@c3024 c3024 changed the title [Internal QA] Add Vendor filter to expense Search Add Vendor filter to expense Search Sep 17, 2026
@melvin-bot

melvin-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant