Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
heyjennahay
left a comment
There was a problem hiding this comment.
As an admin whose only eligible workspace is Xero (vendorMatching beta), verify the header and picker read "Supplier".
To clarify, we should use Vendor across all integrations types including Xero
|
@c3024 conflicts, sorry - and can you also check to make sure that we still use the term "Vendor" for Xero? 🙏 |
|
Just want to confirm before replacing it: The Design doc R4 says to set the rule the issue points to: “All UI copy uses ‘Supplier’ (Xero's term for vendors) rather than ‘Vendor’”, with “Expense field label: ‘Supplier’” and “Workspace tab label: ‘Suppliers’.” Xero calls vendors Contacts marked as Supplier, so the doc keeps Xero-facing copy aligned with Xero's terminology. The linked issue says to resolve values “using the same integration-aware naming and data sources as the existing vendor field (including Xero's ‘Supplier’ terminology where applicable).” The main branch already implements this rule for the expense field. Should we replace the column name in the Money Request report view and remove the special Xero check ( |
…or-column # Conflicts: # src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx
Explanation of Change
Adds a Vendor column to the Search expense table and the single-report table.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/681919
Tests
vendorMatchingbeta), verify the header and picker read "Supplier".Offline tests
QA Steps
Internal QA on staging, same as Tests. Needs a QBO sandbox workspace with company card export set to Credit card or Debit card. The Xero step needs the
vendorMatchingbeta.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari