Conversation
…e is GA Sage Intacct vendor matching shipped in #100455, which removed the vendorMatching beta gate from the Intacct code paths. The help article was hidden behind noindex/sitemap:false while the feature was beta-gated, so publish it and align it with the live UI labels. Co-authored-by: Kio <KioCoan@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to Remove vendor gate intacct, which removed the
vendorMatchingbeta gate from the Sage Intacct code paths and made Sage Intacct vendor matching generally available.The Sage Intacct help article already existed, but it was hidden from the live help site with
noindex: trueandsitemap: falsewhile the feature was beta-gated. The QuickBooks Online article carries no such flags after the equivalent QBO cleanup in [No QA] Remove the QBO vendor matching beta gate, and the Xero article stays indocs/articles/Unlisted/because Xero vendor matching is still pre-GA. This PR brings Sage Intacct in line with the QBO pattern.docs/articles/new-expensify/connections/sage-intacct/Manage-Vendor-Matching-for-Sage-Intacct.mdnoindex: trueandsitemap: falseso the article publishes and is indexed. This is the substantive change — the feature is GA, so the article should no longer be hidden.keywordslist, andinternalScope. The Sage Intacct Export company card expenses as picker rendersworkspace.sageIntacct.nonReimbursableExpenses.values.creditCardCharge, which isCredit cardsinsrc/languages/en.ts:5423. "Credit Card Charges" is the Sage Intacct record name, not the Expensify label.## Where to find your imported Sage Intacct vendorssection. This is the surface the linked PR unhides: the Vendors row on More features and the Vendors page in the Workspace menu. It also states that switching the export to Vendor bills removes them again, which matches the export mode gate that GA did not widen.<!-- SCREENSHOT: -->placeholder. The article pointed atassets/images/2_Awesome_Co_Control_Intacct_-_Accounting.png, which does not exist indocs/assets/images/, so publishing the article as-is would have shipped a broken image.docs/articles/new-expensify/connections/sage-intacct/Configure-Sage-Intacct.mdLabel verification
Every UI label in the changed text was verified rather than assumed:
src/pages/workspace/WorkspaceMoreFeaturesPage/index.tsx:505-592, so the article says Organize, not Integrate.disabledprop and its comment atsrc/pages/workspace/WorkspaceMoreFeaturesPage/index.tsx:581.src/languages/en.ts, the source of the rendered strings.A Sage Intacct-connected Workspace could not be created in the test environment, so the Intacct-specific labels were verified from the translation source and the rendering components rather than by driving a connected Workspace. Please confirm them against a real Sage Intacct Workspace when you review.
Deliberately out of scope
Configure-Sage-Intacct.mdhas pre-existing heading and capitalization violations ofdocs/HELP_AUTHORING_GUIDELINES.md(# Step 1: Select Entity,## Billable Expenses, and**Expense Reports**/**Vendor Bills**in the out-of-pocket section). Only the section this PR touches was corrected; restructuring that article belongs in its own PR.docs/articles/Unlisted/, and no Rillet or DualEntry article was added, because those integrations are still gated byCONST.BETAS.VENDOR_MATCHING.<!-- SCREENSHOT: -->placeholder.Fixed Issues
$ #100455
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
For reference, these checks were run on the branch:
npm run spell-changed— 2 files checked, 0 issues.docs/HELP_AUTHORING_GUIDELINES.md: exactly one#title plus the exempt# FAQ, only##section headings, every section heading starts with a question word or an action verb, at least one "How to" heading, and the screenshot placeholder uses the required non-rendered comment format.noindexorsitemap, and that the new cross-link uses the same relative link shape as the QBO configuration article.Offline tests
Not applicable. This PR changes help site markdown only and ships no app code.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
Help site content only — consider adding "[No QA]" to the title if QA has nothing to verify here.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Not applicable — help site markdown only, no app UI changes.
@KioCoan, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.