Conversation
Co-authored-by: Nguyen Van Duc <dukenv0307@users.noreply.github.com>
Contributor
Author
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for warn when leaving a workspace with reports to approve (
Expensify/App#101352).That PR broadened when the leave-workspace approver warning appears: a member who has any report currently waiting for their approval now sees "If you leave this workspace, you'll be replaced in the approval workflow by [owner], the workspace owner" — even when they aren't set as an approver in the workspace's approval workflow, for example when an admin routed a report to them with Change approver.
The help site had no coverage of a member leaving a workspace at all, so there was nowhere for that warning to be explained. These changes add it:
docs/articles/new-expensify/workspaces/Leave-a-Workspace.md— how to leave a workspace from the Workspaces list and from the workspace Overview page, what each leave confirmation message means and the order Expensify picks between them, when the approver message appears (including the Change approver case this PR added), and what happens after you leave.Add-Approvals.md— adds "An approver leaves the workspace" to the existing FAQ list of automatic approver reassignment triggers, which previously only covered an admin removing an approver.Managing-Workspace-Members.md— adds a note under Remove Workspace Members that members can remove themselves, linking to the new article.Authored against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: one workflow per article, a single#title plus# FAQ, task-based##headings only,internalScopemetadata, relative cross-links kept outside numbered steps, and the three dots written as (⋮).UI labels used in the article come from the live web app and the current source strings:
common.leave,common.leaveWorkspaceTitle,common.cancel, andcommon.buttonConfirm. These could not be exercised in the live app because the test account owns its only workspace, and the leave action is gated behind!isOwner.Fixed Issues
$ #98764
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@dukenv0307, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.