Skip to content

Docs updates for E/A#101352 Document leaving a workspace and approver warning - #101486

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsLeaveWorkspaceApproverWarning
Draft

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsLeaveWorkspaceApproverWarning

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for warn when leaving a workspace with reports to approve (Expensify/App#101352).

That PR broadened when the leave-workspace approver warning appears: a member who has any report currently waiting for their approval now sees "If you leave this workspace, you'll be replaced in the approval workflow by [owner], the workspace owner" — even when they aren't set as an approver in the workspace's approval workflow, for example when an admin routed a report to them with Change approver.

The help site had no coverage of a member leaving a workspace at all, so there was nowhere for that warning to be explained. These changes add it:

  • New article docs/articles/new-expensify/workspaces/Leave-a-Workspace.md — how to leave a workspace from the Workspaces list and from the workspace Overview page, what each leave confirmation message means and the order Expensify picks between them, when the approver message appears (including the Change approver case this PR added), and what happens after you leave.
  • Add-Approvals.md — adds "An approver leaves the workspace" to the existing FAQ list of automatic approver reassignment triggers, which previously only covered an admin removing an approver.
  • Managing-Workspace-Members.md — adds a note under Remove Workspace Members that members can remove themselves, linking to the new article.

Authored against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: one workflow per article, a single # title plus # FAQ, task-based ## headings only, internalScope metadata, relative cross-links kept outside numbered steps, and the three dots written as (⋮).

UI labels used in the article come from the live web app and the current source strings:

  • Workspaces navigation tab, and the Overview and Members items in the workspace settings menu — verified in the live web app.
  • More dropdown on the workspace Overview page — verified in the live web app.
  • Leave (the menu item in both the row three dots menu and the More dropdown), the Leave [workspace name]? modal title, and the Leave / Cancel / Got it buttons — taken from common.leave, common.leaveWorkspaceTitle, common.cancel, and common.buttonConfirm. These could not be exercised in the live app because the test account owns its only workspace, and the leave action is gated behind !isOwner.

Fixed Issues

$ #98764
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@dukenv0307, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Nguyen Van Duc <dukenv0307@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 17, 2026 22:39
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 17, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-docsLeaveWorkspaceApproverWarning
git checkout -b claude-docsLeaveWorkspaceApproverWarning upstream/claude-docsLeaveWorkspaceApproverWarning
git push -u origin claude-docsLeaveWorkspaceApproverWarning

Then you can close this PR and open a new one from your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants