Conversation
Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
52 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for [Bug] Hide cancelled reservations from Upcoming (
Expensify/App#101385), which stopped canceled travel reservations from appearing in the Upcoming travel section on Home.The Home help article already documented the Upcoming travel section, but it stated the opposite of the new behavior:
That sentence is now wrong, so this updates the docs to match:
docs/articles/new-expensify/getting-started/Expensify-Home-Overview.mdkeywords.docs/articles/travel/managing-trips/Canceling-Travel-Arrangements.mdAuthoring compliance: only
##headings, each starting with a question word; UI labels bolded and matched exactly againstsrc/languages/en.ts(Upcoming travel,Canceled,Flight to …,Hotel in …,Car rental in …,Train to …,Today,In 1 day,In 1 week); relative cross-links only; no new screenshots, since the change is behavioral rather than a new control to locate.npm run spell-changedreports 0 issues.Fixed Issues
$ #101054
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — help site markdown only, no app UI changes.
Android: mWeb Chrome
N/A — help site markdown only, no app UI changes.
iOS: Native
N/A — help site markdown only, no app UI changes.
iOS: mWeb Safari
N/A — help site markdown only, no app UI changes.
MacOS: Chrome / Safari
N/A — help site markdown only, no app UI changes.
@rlinoz, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.