Conversation
The wide-layout Selected dropdown on the Search pages was replaced by a floating bulk action bar, so every web instruction that said to click Selected at the top no longer matches the product. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
54 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Use a floating action bar for bulk actions, which replaced the wide-layout bulk actions Selected dropdown on the Search pages with a floating bulk action bar at the bottom of the list.
Why the docs had to change: 20 step-by-step instructions across 13 articles told web users to click Selected at the top of the page. That control no longer exists on web, so following those steps now leads nowhere.
What changed in the product (verified against the live UI on web at 1600x900):
Esc.Approach taken in the docs:
Because web and mobile now differ on one step only, that step names both platforms rather than duplicating each whole procedure:
The "if you don't see it, select More" hedge is deliberate: the bar decides at render time which actions get buttons, so no article can safely promise a given action is a button.
Getting-Started-with-the-Spend-Page.mdgets one new## How to use the bulk action bar on the Expenses and Reports pagessection that explains the bar once, so the per-step instructions stay short.Deliberately left alone:
How-to-Merge-Expenses.md,How-to-Delete-Expenses.md) — the report view still uses Selected.Getting-Started-with-the-Spend-Page.md— same reason.One incidental fix: the grouped-export steps in
Search-and-Download-Expenses.mdwere missing the Export step between selecting rows and choosing Current view.Files changed (13):
View-and-Reconcile-Expensify-Card-Expenses.md,Adding-Attendees.md,Approve-Expenses.md,Create-and-Submit-Reports.md,Duplicate-a-Report.md,Edit-Expenses.md,Getting-Started-with-the-Spend-Page.md,How-to-Delete-Expenses.md,How-to-Duplicate-an-Expense.md,How-to-Export-Expenses.md,How-to-Export-Reports.md,How-to-Merge-Expenses.md,Search-and-Download-Expenses.md.Applied
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md.npm run spell-changedpasses on all 13 files (0 issues).Fixed Issues
$ #98651
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.