[CP Staging] Revert "Show the category description hint on the expense creation description field"

[mountiny]

Reverts #101072

### Fixed issues
$ #101512
$ #101519
$ #101556

[melvin-bot]

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #101557.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7910636-8e95645-344342483a5f344778d83508452ff7215e22754c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7910636-8e95645-acbf93bd428d43a2ba9408cd5e7ef90105100ad7/index.html

Web 🕸️
https://101557.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[os-botify]

🔁 Filed a Staging retest request for deploy blockers #101512, #101556 after this PR was cherry-picked to staging.

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.84-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 No help site changes are required for this revert. No draft PR created.

Why: This PR only removes the inline category description hint from the expense creation confirmation page. The Description hint feature itself is untouched — admins still set it per category, and it still renders on the dedicated Description step at src/pages/iou/request/step/DynamicIOURequestStepDescription.tsx:189.

The two help articles that mention it describe only the admin-side setting, never where the hint surfaces during expense creation, so both remain accurate:

Article	Line	Current text
Create-expense-categories.md:131	131	"Description hint – Remind members what information to provide when they use this category."
Workspace-Rules.md:161	161	"Open a category to set its Approver and Description hint…"

Verification details

• Diff reviewed: only DescriptionField.tsx (−10) and its unit test (deleted). No docs/ files touched, and the reverted PR Show the category description hint on the expense creation description field didn't touch docs/ either.
• Searched all of docs/articles for hint, description hint, commentHint, and category description — only the two lines above matched.
• Label capitalization checked against the shipped UI strings: Description hint and Hint at src/languages/en.ts:8635-8638. Both articles already match, so nothing needed correcting. I verified against the source strings rather than a live browser session, since no copy had to be written.
• One thing worth a look, but not a help site item: the in-product subtitle at src/languages/en.ts:8637 tells admins "This hint appears in the description field on expenses." That's still true on the Description step, but it's now less true of the confirmation page. If the revert is permanent, you may want to tighten that string in a follow-up.

Since there is no help site PR to link, there is nothing for you to review or mark Ready for review. If you'd rather I document the hint's placement explicitly (or reword the in-product string above), reply with @MelvinBot <what you want> and I'll open a draft PR.

---

view run

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.86-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 No help site changes are required for this revert. I did not create a draft PR.

Why: the help site never documented where the category description hint renders, so reverting where it renders doesn't make any article wrong.

The two places App/docs/articles mention the feature only describe setting it on a category:

• docs/articles/new-expensify/workspaces/Create-expense-categories.md:131 — "Description hint – Remind members what information to provide when they use this category."
• docs/articles/new-expensify/workspaces/Workspace-Rules.md:161 — lists Description hint as something you set by opening a category.

Neither states that the hint appears on the expense creation confirmation screen, and after this revert the hint still renders in the Description step at DynamicIOURequestStepDescription.tsx:189. Both sentences remain accurate.

Supporting detail

What this PR changes. It reverts Show the category description hint on the expense creation description field, removing hint / shouldRenderHintAsHTML from the inline description TextInput on the confirmation list (DescriptionField.tsx) and deleting its unit test. It touches no other behavior.

No docs drift was introduced. PR 101072 shipped zero files under docs/, so there is no help site content describing the added behavior that now needs to be pulled back out. The revert restores the behavior the articles were already written against.

The in-product copy is unaffected either way. src/languages/en.ts:8635-8637 still reads "Remind employees to provide additional information for "" spend. This hint appears in the description field on expenses." — still true for the Description field on an expense.

Out of scope, flagged only: docs/articles/expensify-classic/workspaces/Enable-and-set-up-expense-violations.md:45 also mentions a Description Hint, but that is an Expensify Classic article and this PR only changes New Expensify.

Label grounding: I verified "Description hint" against src/languages/en.ts:8635, the string the live UI renders, rather than driving the app — since no article copy is being written, there was no new label to check against a running build. If you would rather I drive the web build to confirm the post-revert behavior end to end, say the word and I will.

---

@mountiny — there is no linked help site PR to review, because no article needs to change. If you think one of the two articles above should be more specific about where the hint appears (for example, calling out that it shows on the Description field rather than on the expense creation confirmation screen), reply and I'll open the draft PR for it.

---

view run

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.89-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

• Android

[MelvinBot]

🤖 Still no help site changes required for this revert — and I've now confirmed it against the live UI, which is the verification I offered in my last comment. I did not create a draft PR.

Live verification on dev NewDot web (local build at the revert commit db1dad6):

Step	Status
Setting label on a category is exactly Description hint Workspace > Categories > Advertising shows a menu item titled exactly "Description hint" — matching the capitalization used in both articles.	✅
Hint saves and persists on the category Set "Client name", saved, navigated away and back — value retained.	✅
Hint does NOT appear on the expense creation confirmation page With Category = Advertising, the Description field is a plain inline input labeled only "Description" — no hint node. This is exactly what the revert removed.	✅
Hint DOES still appear on the dedicated Description page Opening the expense's Description row shows the "Client name" hint below the input.	✅

So the feature still works where the articles say it does. Neither Create-expense-categories.md:131 nor Workspace-Rules.md:161 claims the hint renders during expense creation — they only describe setting it on a category — so nothing in them became wrong.

---

One separate, pre-existing gap I found — your call

This is not caused by this PR, so I left it out of scope rather than bundling it into a revert-docs PR.

Testing showed that Description hint is gated twice: the Category rules section only appears once the workspace Rules feature is enabled, and actually saving a hint requires the Control plan (Collect shows an "Unlock this feature" upgrade wall).

Create-expense-categories.md is careful about this everywhere else — it marks Approver as "(on the Control plan)" on line 14 and flags GL codes as Control-only on line 86 and line 92. But the Description hint bullet on line 131 carries no plan note, so a Collect-plan admin following that section hits an upgrade wall the article didn't warn them about.

Reply and I'll open a draft PR adding the plan note (labelled HelpDot, assigned to you). I'd keep it to a one-line change on line 131 for consistency with line 14.

Why I'm confident no revert-driven change is needed

• Neither PR shipped docs. Show the category description hint on the expense creation description field changed only DescriptionField.tsx and its unit test — zero files under docs/. There is no help site content describing the added behavior that now needs pulling back out. The revert restores the behavior the articles were already written against.
• The authoring spec doesn't require documenting render locations. docs/HELP_AUTHORING_GUIDELINES.md requires task-based headings and UI-exact labels (§1, §6). Both articles describe the admin task of setting the hint, which is unchanged.
• In-product copy is unaffected. src/languages/en.ts:8635-8637 still reads "This hint appears in the description field on expenses." — verified true on the dedicated Description page above.
• Out of scope: Enable-and-set-up-expense-violations.md:45 also mentions a Description Hint, but that's an Expensify Classic article and this PR only touches New Expensify.

---

@mountiny — there's no linked help site PR to review, because this revert doesn't require one. The only open question is the Control-plan note described above; say the word and I'll open that draft PR.

---

view run · view recording

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.90-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅