Skip to content

[CP Staging] Revert "Show the category description hint on the expense creation description field" #101557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
Sep 18, 2026
+1 −106
Merged

[CP Staging] Revert "Show the category description hint on the expense creation description field" #101557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import MentionReportContext from '@components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/MentionReportContext';
import MenuItemWithTopDescription from '@components/MenuItemWithTopDescription';
import {useConfirmationFields} from '@components/MoneyRequestConfirmationFields/context';
import usePolicyCategoriesForConfirmation from '@components/MoneyRequestConfirmationList/hooks/usePolicyCategoriesForConfirmation';
import {ShowContextMenuActionsContext, ShowContextMenuStateContext} from '@components/ShowContextMenuContext';
import TextInput from '@components/TextInput';

Expand Down Expand Up @@ -30,7 +29,7 @@ import type {OnyxEntry} from 'react-native-onyx';
import React, {useRef} from 'react';
import {View} from 'react-native';

import {categoryStateSelector, descriptionStateSelector} from './selectors';
import {descriptionStateSelector} from './selectors';
import useTransactionSelector from './useTransactionSelector';

type DescriptionFieldProps = {
Expand All @@ -50,12 +49,6 @@ function DescriptionField({isDescriptionRequired, policy}: DescriptionFieldProps
const [splitDraftTransaction] = useOnyx(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${transactionID}`);

const descriptionState = useTransactionSelector(transactionID, descriptionStateSelector);
const categoryState = useTransactionSelector(transactionID, categoryStateSelector);
const policyCategories = usePolicyCategoriesForConfirmation(policy?.id);

// A category can carry a hint telling the user what to write in the description, so show it under the input once
// that category is selected, the same way the dedicated description step does.
const descriptionHint = categoryState?.category ? (policyCategories?.[categoryState.category]?.commentHint ?? '') : '';

// `getDescription` returns raw `transaction.comment.comment`, which can be HTML for saved transactions.
// We normalize to markdown so both the read-only and editable inputs receive a consistent format.
Expand Down Expand Up @@ -123,8 +116,6 @@ function DescriptionField({isDescriptionRequired, policy}: DescriptionFieldProps
maxAutoGrowHeight={variables.textInputAutoGrowMaxHeight}
type="markdown"
excludedMarkdownStyles={!policy ? ['mentionReport'] : []}
hint={descriptionHint}
shouldRenderHintAsHTML={!!descriptionHint}
/>
</View>
) : (
Expand Down
96 changes: 0 additions & 96 deletions tests/unit/components/MoneyRequestConfirmationList/DescriptionField.test.tsx
View file
Open in desktop

This file was deleted.

Loading