Conversation
…operator FAQ Co-authored-by: Lukasz Modzelewski <LukasMod@users.noreply.github.com>
53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help-site follow-up to [CP Staging] Search error state, distinguish stale search results from a real request failure, which splits the Search error view into three distinct states.
The FAQ answer for What happens if I enter an invalid operator? in
Use Search Operators to Filter and Analyzesaid the system ignores an unrecognized operator and returns results from the valid parts of the query. That is not what happens: an unrecognized operator or value is rejected outright and the results are replaced by an error page. That answer was already wrong before PR #101554 and would have stayed wrong after it, so it is corrected here.This PR also adds a
## How to troubleshoot search operator errors in Expensifysection covering all three states a search can end in, because after PR #101554 they are no longer interchangeable and a member needs to know which one requires fixing the query and which one requires running the search again:Every message, button, and toggle label above was read off the running app on the PR #101554 branch rather than from the source, per the naming conventions in
docs/HELPSITE_NAMING_CONVENTIONS.md. The article followsdocs/HELP_AUTHORING_GUIDELINES.md: one#title plus# FAQ, all content under##, and the new heading starts with "How to".npm run spell-changedpasses.A screenshot placeholder is included as an HTML comment for the first state, since members most often mistake it for an empty result set.
Verified UI states
Fixed Issues
$
PROPOSAL:
No issue was filed for this docs update. It was requested on [CP Staging] Search error state, distinguish stale search results from a real request failure.
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@LukasMod, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.