Skip to content

chore: drop redundant root .env.example#55

Open
mmletgo wants to merge 1 commit into
ExplosiveCoderflome:mainfrom
mmletgo:chore/drop-root-env-example
Open

chore: drop redundant root .env.example#55
mmletgo wants to merge 1 commit into
ExplosiveCoderflome:mainfrom
mmletgo:chore/drop-root-env-example

Conversation

@mmletgo
Copy link
Copy Markdown

@mmletgo mmletgo commented May 18, 2026

Summary

  • 根目录 .env.example 从未被任何运行入口加载(dotenv/config 只在 server/ 内调用,前端走 Vite 的 client/.env*),仅作为"聚合参考"。
  • 它已经和子包示例发生漂移,会误导第一次复制配置的用户。例如:
    • HOST / ALLOW_LAN / CORS_ORIGIN 默认值不同
    • SILICONFLOW_MODEL:根是 Qwen2.5-72B-Instructserver/Qwen2.5-7B-Instruct
    • 根少了 BOOK_ANALYSIS_MAX_CONCURRENT_TASKS / NOTES_CONCURRENCY / SECTION_CONCURRENCY / CACHE_SEGMENT_VERSION
    • server/ 少了 BOOK_ANALYSIS_LLM_TIMEOUT_MS
  • 删除该文件,把 README.mddocs/README.md 中的指引直接指向 server/.env.example + client/.env.example,删掉"根目录 example 是总览参考"的提法。

Test plan

  • pnpm dev 仍能正常启动:server 读 server/.env,client 读 client/.env*,根 example 删除不影响任何运行入口
  • README "2. 配置环境变量" 小节中两个 example 链接可点击跳转
  • docs/README.md 的"根目录保留规则"已同步去掉 .env.example

🤖 Generated with Claude Code

Root .env.example was never loaded by any runtime entry — `dotenv/config`
only runs inside server/ and Vite only reads client/.env*. Keeping it as
an "aggregate reference" caused drift from server/.env.example and
client/.env.example (HOST/ALLOW_LAN/CORS_ORIGIN defaults, SILICONFLOW_MODEL,
BOOK_ANALYSIS_* keys all out of sync).

Removed the file and updated README + docs/README to point users straight
at the per-workspace examples.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 18, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant