Skip to content

Fix double wrapping of algebraic model answers#321

Merged
PhilippImhof merged 1 commit intoFormulasQuestion:mainfrom
PhilippImhof:fix-quotes
Apr 4, 2026
Merged

Fix double wrapping of algebraic model answers#321
PhilippImhof merged 1 commit intoFormulasQuestion:mainfrom
PhilippImhof:fix-quotes

Conversation

@PhilippImhof
Copy link
Copy Markdown
Collaborator

Until #257, we simply ignored if an algebraic formula was to be wrapped in quotes a second time. With that PR, we started to throw an error, in order to disallow usage of strings by students.

When creating or editing a question, checking the model answers could lead to the formula being wrapped more than once. This PR fixes the problem.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 4, 2026

Pull Request Test Coverage Report for Build 23984182459

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 97.498%

Totals Coverage Status
Change from base Build 23112103126: -0.001%
Covered Lines: 4598
Relevant Lines: 4716

💛 - Coveralls

@PhilippImhof PhilippImhof merged commit cab1b05 into FormulasQuestion:main Apr 4, 2026
24 of 25 checks passed
@PhilippImhof PhilippImhof deleted the fix-quotes branch April 4, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants